| Message ID | 1400766516-14537-4-git-send-email-ivan.khoronzhuk@ti.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
Why do I only have this patch? Where is the rest of the set? Also, it's on v5 and I don't recall seeing the other 4 versions? > The Keystone II devices have a set of registers that are used to control > the status of its peripherals. This node is intended to allow access to > this functionality. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com> > --- > .../devicetree/bindings/mfd/ti-keystone-devctrl.txt | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt > > diff --git a/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt > new file mode 100644 > index 0000000..35f7a66 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt > @@ -0,0 +1,19 @@ > +* Device tree bindings for Texas Instruments keystone device state control > + > +The Keystone II devices have a set of registers that are used to control > +the status of its peripherals. This node is intended to allow access to > +this functionality. > + > +Required properties: > + > +- compatible: "ti,keystone-devctrl", "syscon" > + > +- reg: contains offset/length value for pll controller > + registers space. Why have you tabbed out all that way? > +Example: > + > +devctrl: device-state-control { This node needs an address: devctrl: device-state-control@02620000 { > + compatible = "ti,keystone-devctrl", "syscon"; > + reg = <0x02620000 0x1000>; > +};
On 05/22/2014 05:14 PM, Lee Jones wrote: > Why do I only have this patch? Where is the rest of the set? Also, > it's on v5 and I don't recall seeing the other 4 versions? It's strange I've sent whole series on linux-kernel@vger.kernel.org linux-arm-kernel@lists.infradead.org linux-doc@vger.kernel.org devicetree@vger.kernel.org v4 is also was sent to lists in question: https://lkml.org/lkml/2014/5/21/359 >> The Keystone II devices have a set of registers that are used to control >> the status of its peripherals. This node is intended to allow access to >> this functionality. >> >> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com> >> --- >> .../devicetree/bindings/mfd/ti-keystone-devctrl.txt | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt >> new file mode 100644 >> index 0000000..35f7a66 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt >> @@ -0,0 +1,19 @@ >> +* Device tree bindings for Texas Instruments keystone device state control >> + >> +The Keystone II devices have a set of registers that are used to control >> +the status of its peripherals. This node is intended to allow access to >> +this functionality. >> + >> +Required properties: >> + >> +- compatible: "ti,keystone-devctrl", "syscon" >> + >> +- reg: contains offset/length value for pll controller >> + registers space. > Why have you tabbed out all that way? I'll correct > >> +Example: >> + >> +devctrl: device-state-control { > This node needs an address: > > devctrl: device-state-control@02620000 { Thanks! I will correct >> + compatible = "ti,keystone-devctrl", "syscon"; >> + reg = <0x02620000 0x1000>; >> +};
> >Why do I only have this patch? Where is the rest of the set? Also, > >it's on v5 and I don't recall seeing the other 4 versions? > > It's strange I've sent whole series on > > linux-kernel@vger.kernel.org > linux-arm-kernel@lists.infradead.org > linux-doc@vger.kernel.org > devicetree@vger.kernel.org > > v4 is also was sent to lists in question: > https://lkml.org/lkml/2014/5/21/359 But did you send them to me? I don't parse the list.
On 05/22/2014 06:33 PM, Lee Jones wrote: >>> Why do I only have this patch? Where is the rest of the set? Also, >>> it's on v5 and I don't recall seeing the other 4 versions? >> It's strange I've sent whole series on >> >> linux-kernel@vger.kernel.org >> linux-arm-kernel@lists.infradead.org >> linux-doc@vger.kernel.org >> devicetree@vger.kernel.org >> >> v4 is also was sent to lists in question: >> https://lkml.org/lkml/2014/5/21/359 > But did you send them to me? I don't parse the list. > Sorry. Becouse /scripts/get_maintainer.pl patches/reset_driver_v6/* hadn't been listed you It's because there is no patch with "code" for the bindings you've comment. I should check it by hand for mtd. The bindings for mtd device_state_control were added only on v5 And it's added only to describe what is the node we've used in a keystone DT. The node is planned to be used only via syscon phandle, there is no driver for it, and compatible string for "ti,keystone-devctrl" added only to be matched by a high-level device driver if needed. I'll send new v6 series to you also. Once again sorry.
On 05/22/2014 07:14 PM, Ivan Khoronzhuk wrote: > > On 05/22/2014 06:33 PM, Lee Jones wrote: >>>> Why do I only have this patch? Where is the rest of the set? Also, >>>> it's on v5 and I don't recall seeing the other 4 versions? >>> It's strange I've sent whole series on >>> >>> linux-kernel@vger.kernel.org >>> linux-arm-kernel@lists.infradead.org >>> linux-doc@vger.kernel.org >>> devicetree@vger.kernel.org >>> >>> v4 is also was sent to lists in question: >>> https://lkml.org/lkml/2014/5/21/359 >> But did you send them to me? I don't parse the list. >> > > Sorry. > Becouse /scripts/get_maintainer.pl patches/reset_driver_v6/* hadn't > been listed you > It's because there is no patch with "code" for the bindings you've > comment. > > I should check it by hand for mtd. > > The bindings for mtd device_state_control were added only on v5 > And it's added only to describe what is the node we've used in a > keystone DT. > The node is planned to be used only via syscon phandle, there is no > driver for it, > and compatible string for "ti,keystone-devctrl" added only to be > matched by > a high-level device driver if needed. > > I'll send new v6 series to you also. > Once again sorry. > s/mtd/mfd
diff --git a/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt new file mode 100644 index 0000000..35f7a66 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt @@ -0,0 +1,19 @@ +* Device tree bindings for Texas Instruments keystone device state control + +The Keystone II devices have a set of registers that are used to control +the status of its peripherals. This node is intended to allow access to +this functionality. + +Required properties: + +- compatible: "ti,keystone-devctrl", "syscon" + +- reg: contains offset/length value for pll controller + registers space. + +Example: + +devctrl: device-state-control { + compatible = "ti,keystone-devctrl", "syscon"; + reg = <0x02620000 0x1000>; +};
The Keystone II devices have a set of registers that are used to control the status of its peripherals. This node is intended to allow access to this functionality. Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com> --- .../devicetree/bindings/mfd/ti-keystone-devctrl.txt | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/ti-keystone-devctrl.txt