Message ID | 4ACBA06A.6050208@gmail.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
On Tue, Oct 6, 2009 at 9:54 PM, Roel Kluin <roel.kluin@gmail.com> wrote: > in update_rx_stats() the RX_OVERLEN bit is set twice, replace it by RX_RUNT. > in au1000_rx() the RX_MISSED_FRAME bit was tested a few lines earlier already > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > please review, I merely guessed it should be RX_RUNT. > > diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c > index fdf5937..04f63c7 100644 > --- a/drivers/net/au1000_eth.c > +++ b/drivers/net/au1000_eth.c > @@ -721,7 +721,7 @@ static inline void update_rx_stats(struct net_device *dev, u32 status) > ps->rx_errors++; > if (status & RX_MISSED_FRAME) > ps->rx_missed_errors++; > - if (status & (RX_OVERLEN | RX_OVERLEN | RX_LEN_ERROR)) > + if (status & (RX_OVERLEN | RX_RUNT | RX_LEN_ERROR)) > ps->rx_length_errors++; > if (status & RX_CRC_ERROR) > ps->rx_crc_errors++; > @@ -794,8 +794,6 @@ static int au1000_rx(struct net_device *dev) > printk("rx len error\n"); > if (status & RX_U_CNTRL_FRAME) > printk("rx u control frame\n"); > - if (status & RX_MISSED_FRAME) > - printk("rx miss\n"); Yeah, looks right. Acked-by: Manuel Lauss <manuel.lauss@gmail.com> Manuel Lauss -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Manuel Lauss <manuel.lauss@googlemail.com> Date: Tue, 6 Oct 2009 21:53:50 +0200 > On Tue, Oct 6, 2009 at 9:54 PM, Roel Kluin <roel.kluin@gmail.com> wrote: >> in update_rx_stats() the RX_OVERLEN bit is set twice, replace it by RX_RUNT. >> in au1000_rx() the RX_MISSED_FRAME bit was tested a few lines earlier already >> >> Signed-off-by: Roel Kluin <roel.kluin@gmail.com> ... > > Yeah, looks right. > > Acked-by: Manuel Lauss <manuel.lauss@gmail.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c index fdf5937..04f63c7 100644 --- a/drivers/net/au1000_eth.c +++ b/drivers/net/au1000_eth.c @@ -721,7 +721,7 @@ static inline void update_rx_stats(struct net_device *dev, u32 status) ps->rx_errors++; if (status & RX_MISSED_FRAME) ps->rx_missed_errors++; - if (status & (RX_OVERLEN | RX_OVERLEN | RX_LEN_ERROR)) + if (status & (RX_OVERLEN | RX_RUNT | RX_LEN_ERROR)) ps->rx_length_errors++; if (status & RX_CRC_ERROR) ps->rx_crc_errors++; @@ -794,8 +794,6 @@ static int au1000_rx(struct net_device *dev) printk("rx len error\n"); if (status & RX_U_CNTRL_FRAME) printk("rx u control frame\n"); - if (status & RX_MISSED_FRAME) - printk("rx miss\n"); } } prxd->buff_stat = (u32)(pDB->dma_addr | RX_DMA_ENABLE);
in update_rx_stats() the RX_OVERLEN bit is set twice, replace it by RX_RUNT. in au1000_rx() the RX_MISSED_FRAME bit was tested a few lines earlier already Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- please review, I merely guessed it should be RX_RUNT. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html