| Message ID | 1400704153-26626-1-git-send-email-computersforpeace@gmail.com |
|---|---|
| State | Accepted |
| Commit | 897f3a18b0bbe466b7405d96bc99550578d5b145 |
| Headers | show |
On Wed, May 21, 2014 at 01:29:13PM -0700, Brian Norris wrote: > Not all architectures implement a writel_relaxed() accessor. Hopefully > this will change eventually, but for now, this means lpddr2_nvm.c can't > compile on some architectures. > > Let's add an ARM dependency for now, and leave a comment so maybe we can > change this in the future. > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > Cc: Vincenzo Aliberti <vincenzo.aliberti@gmail.com> Pushed to l2-mtd.git, to stop people from reporting build failures on x86. Brian
Brian, as discussed this solution is fine for me Vincenzo On Wed, May 21, 2014 at 10:29 PM, Brian Norris <computersforpeace@gmail.com> wrote: > Not all architectures implement a writel_relaxed() accessor. Hopefully > this will change eventually, but for now, this means lpddr2_nvm.c can't > compile on some architectures. > > Let's add an ARM dependency for now, and leave a comment so maybe we can > change this in the future. > > Signed-off-by: Brian Norris <computersforpeace@gmail.com> > Cc: Vincenzo Aliberti <vincenzo.aliberti@gmail.com> > --- > drivers/mtd/lpddr/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig > index 468f06dea45d..3a19cbee24d7 100644 > --- a/drivers/mtd/lpddr/Kconfig > +++ b/drivers/mtd/lpddr/Kconfig > @@ -19,7 +19,8 @@ config MTD_QINFO_PROBE > Flash products > > config MTD_LPDDR2_NVM > - depends on MTD > + # ARM dependency is only for writel_relaxed() > + depends on MTD && ARM > tristate "Support for LPDDR2-NVM flash chips" > help > This option enables support of PCM memories with a LPDDR2-NVM > -- > 1.8.3.2 >
diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig index 468f06dea45d..3a19cbee24d7 100644 --- a/drivers/mtd/lpddr/Kconfig +++ b/drivers/mtd/lpddr/Kconfig @@ -19,7 +19,8 @@ config MTD_QINFO_PROBE Flash products config MTD_LPDDR2_NVM - depends on MTD + # ARM dependency is only for writel_relaxed() + depends on MTD && ARM tristate "Support for LPDDR2-NVM flash chips" help This option enables support of PCM memories with a LPDDR2-NVM
Not all architectures implement a writel_relaxed() accessor. Hopefully this will change eventually, but for now, this means lpddr2_nvm.c can't compile on some architectures. Let's add an ARM dependency for now, and leave a comment so maybe we can change this in the future. Signed-off-by: Brian Norris <computersforpeace@gmail.com> Cc: Vincenzo Aliberti <vincenzo.aliberti@gmail.com> --- drivers/mtd/lpddr/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)