| Message ID | 537C6FB1.4020305@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
On Wed, 2014-05-21 at 17:19 +0800, hujianyang wrote: > Function ubifs_read_one_lp will not set @lp and returns > an error when ubifs_read_one_lp failed. We should not > perform ubifs_dump_lprop in this case because @lp is not > initialized as we wanted. > > Signed-off-by: hujianyang <hujianyang@huawei.com> Pushed to linux-ubifs.git, thanks!
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c index 5157b86..177b015 100644 --- a/fs/ubifs/debug.c +++ b/fs/ubifs/debug.c @@ -745,8 +745,10 @@ void ubifs_dump_lprops(struct ubifs_info *c) for (lnum = c->main_first; lnum < c->leb_cnt; lnum++) { err = ubifs_read_one_lp(c, lnum, &lp); - if (err) + if (err) { ubifs_err("cannot read lprops for LEB %d", lnum); + continue; + } ubifs_dump_lprop(c, &lp); }
Function ubifs_read_one_lp will not set @lp and returns an error when ubifs_read_one_lp failed. We should not perform ubifs_dump_lprop in this case because @lp is not initialized as we wanted. Signed-off-by: hujianyang <hujianyang@huawei.com> --- fs/ubifs/debug.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)