diff mbox

[v2,2/2] infra: pkg-utils.mk replace "echo -en" with printf

Message ID 1400660710-15758-2-git-send-email-maxime.hadjinlian@gmail.com
State Accepted
Commit 9725c5aefc5861e7eb9736f9228265a5d1a7e998
Headers show

Commit Message

Maxime Hadjinlian May 21, 2014, 8:25 a.m. UTC
printf is POSIX-compliant, echo -e/n is not.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
---
Changes v1 -> v2:
    - Add a trailing \n while retaining splitted lines (Peter Korsgaard,
      Thomas De Schampheleire)
---
 package/pkg-utils.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Peter Korsgaard May 21, 2014, 8:46 a.m. UTC | #1
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 > printf is POSIX-compliant, echo -e/n is not.

This place didn't actually use 'echo -n', so I've adjusted the commit
message and committed, thanks.
diff mbox

Patch

diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
index da3f0fc..c627a64 100644
--- a/package/pkg-utils.mk
+++ b/package/pkg-utils.mk
@@ -110,8 +110,8 @@  define legal-manifest # pkg, version, license, license-files, source, {HOST|TARG
 endef
 
 define legal-license-header # pkg, license-file, {HOST|TARGET}
-	echo -e "$(LEGAL_INFO_SEPARATOR)\n\t$(1):" \
-		"$(2)\n$(LEGAL_INFO_SEPARATOR)\n\n" >>$(LEGAL_LICENSES_TXT_$(3))
+	printf "$(LEGAL_INFO_SEPARATOR)\n\t$(1):\
+		$(2)\n$(LEGAL_INFO_SEPARATOR)\n\n\n" >>$(LEGAL_LICENSES_TXT_$(3))
 endef
 
 define legal-license-nofiles # pkg, {HOST|TARGET}