diff mbox

samba: disable on AVR32

Message ID 1400570423-26735-1-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Commit 460a093787eb09e7002d12cc2e4f37e568479fd5
Headers show

Commit Message

Thomas Petazzoni May 20, 2014, 7:20 a.m. UTC
samba produces particularly large binaries, and the relocations needed
for it do not fit in the possible relocation mechanisms available on
AVR32. Since samba is very unlikely to be used on AVR32, let's just
disable it, as we've already done for samba4.

Fixes:

  http://autobuild.buildroot.net/results/0142b1d5b8c3f20f1bff76ece646d901407f7490/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/samba/Config.in | 3 +++
 1 file changed, 3 insertions(+)

Comments

Peter Korsgaard May 20, 2014, 7:41 a.m. UTC | #1
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > samba produces particularly large binaries, and the relocations needed
 > for it do not fit in the possible relocation mechanisms available on
 > AVR32. Since samba is very unlikely to be used on AVR32, let's just
 > disable it, as we've already done for samba4.

 > Fixes:

 >   http://autobuild.buildroot.net/results/0142b1d5b8c3f20f1bff76ece646d901407f7490/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/samba/Config.in b/package/samba/Config.in
index c5b7e48..70ff960 100644
--- a/package/samba/Config.in
+++ b/package/samba/Config.in
@@ -2,6 +2,8 @@  config BR2_PACKAGE_SAMBA
 	bool "samba"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU # fork()
+	# binary too large, relocations don't fit
+	depends on !BR2_avr32
 	select BR2_PACKAGE_POPT
 	help
 	  Provides secure, stable and fast file and print services
@@ -14,6 +16,7 @@  config BR2_PACKAGE_SAMBA
 		so choose only the components you need.
 
 comment "samba needs a toolchain w/ threads"
+	depends on !BR2_avr32
 	depends on BR2_USE_MMU
 	depends on !BR2_TOOLCHAIN_HAS_THREADS