diff mbox

[2/3] build: Coverity support

Message ID 20140519163941.13956.59256.stgit@seurat.1015granger.net
State Accepted
Headers show

Commit Message

Chuck Lever May 19, 2014, 4:39 p.m. UTC
The new "covbuild" top-level make target builds the contents of the
cov_int/ directory, which is intermediate output that is fed to
Coverity Scan for analysis.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 .gitignore       |    1 +
 Makefile.am      |   13 ++++++++++++-
 doc/CheckInTests |   13 +++++++------
 3 files changed, 20 insertions(+), 7 deletions(-)
diff mbox

Patch

diff --git a/.gitignore b/.gitignore
index 0c09a4e4c725..12ffd96dfb12 100644
--- a/.gitignore
+++ b/.gitignore
@@ -77,3 +77,4 @@  depcomp
 .libs/
 .stgit*
 py-compile
+cov-int/
diff --git a/Makefile.am b/Makefile.am
index 046280199e10..6bb1e2816f85 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -35,10 +35,21 @@  DISTCLEANFILES		= Makefile.in ChangeLog fedfs-utils*.tar.gz
 ChangeLog:
 	git log > ChangeLog
 
-clean-local: doxyclean
+clean-local: doxyclean covclean
 
 dist-hook: ChangeLog
 
+# Coverity-related targets
+
+.PHONY: covbuild covclean
+
+covbuild:
+	cov-build --dir cov-int make
+	tar czvf /tmp/fedfs-utils-cov-int.tgz cov-int
+
+covclean:
+	$(RM) -rf cov-int
+
 # Doxygen-related targets
 
 .PHONY: doxy doxyclean
diff --git a/doc/CheckInTests b/doc/CheckInTests
index 8375861f41d7..9336a436b989 100644
--- a/doc/CheckInTests
+++ b/doc/CheckInTests
@@ -92,11 +92,13 @@  bisecting to be useful.
  3.  "make -s -j3" must complete without error or new compiler
      or sparse warnings
  4.  "make doxy" must complete with no errors or warnings
- 5.  "make distcheck" must complete without error
- 6.  "make distclean" must complete without error
- 7.  "git status" must produce no output on a clean tree
- 8.  "git clean -d -f -x" does not break anything
- 9.  "git log -p" shows no new white space damage
+ 5.  "make covbuild" must complete with at least 85% compilation
+     units ready for analysis
+ 6.  "make distcheck" must complete without error
+ 7.  "make distclean" must complete without error
+ 8.  "git status" must produce no output on a clean tree
+ 9.  "git clean -d -f -x" does not break anything
+10.  "git log -p" shows no new white space damage
 
 To preserve bisectability, the tree MUST build after each commit.
 
@@ -112,7 +114,6 @@  At some point, we'd like:
  1.  Automated checking of coding style and white space
  2.  Automated fortify or splint testing during check-in
  3.  Automated unit tests
- 4.  Regular runs against coverity
 
 
 Per-release