Patchwork [Trusty] rtlwifi: rtl8723be: disable MSI interrupts mode

login
register
mail settings
Submitter Adam Lee
Date May 16, 2014, 4:52 a.m.
Message ID <1400215941-26344-1-git-send-email-adam.lee@canonical.com>
Download mbox | patch
Permalink /patch/349430/
State New
Headers show

Comments

Adam Lee - May 16, 2014, 4:52 a.m.
BugLink: http://bugs.launchpad.net/bugs/1320070

94010fa0dd07e8b904e7c6b6589f15573008ab15 ("rtlwifi: add MSI interrupts
mode support") introduced MSI interrupts mode support, which seemed
safe enough with RTL8188EE and RTL8723BE as RealTek's testing results,
but some users reported their RTL8188EE modules could not connect to
any wireless network after the MSI mode was enabled by Ubuntu 14.04.

So, let's fallback to pin-based mode until rtlwifi's MSI support get
good compatibility.

BugLink: https://bugs.launchpad.net/bugs/1310512
Signed-off-by: Adam Lee <adam.lee@canonical.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
(cherry picked from commit 329d6e299f92a591acb3a80f6d597a5f9dce7e6d)
---
 drivers/net/wireless/rtlwifi/rtl8723be/sw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Tim Gardner - May 16, 2014, 12:27 p.m.
This patch won't come down via stable since the bad commit was
introduced during the current 3.15 merge window.

Note that it is a cherry-pick from linux-next. Tsk, Tsk.

rtg
Andy Whitcroft - May 16, 2014, 12:51 p.m.
On Fri, May 16, 2014 at 12:52:21PM +0800, Adam Lee wrote:
> BugLink: http://bugs.launchpad.net/bugs/1320070
> 
> 94010fa0dd07e8b904e7c6b6589f15573008ab15 ("rtlwifi: add MSI interrupts
> mode support") introduced MSI interrupts mode support, which seemed
> safe enough with RTL8188EE and RTL8723BE as RealTek's testing results,
> but some users reported their RTL8188EE modules could not connect to
> any wireless network after the MSI mode was enabled by Ubuntu 14.04.
> 
> So, let's fallback to pin-based mode until rtlwifi's MSI support get
> good compatibility.
> 
> BugLink: https://bugs.launchpad.net/bugs/1310512
> Signed-off-by: Adam Lee <adam.lee@canonical.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> (cherry picked from commit 329d6e299f92a591acb3a80f6d597a5f9dce7e6d)

Cannot find this commit in linus' tree?  Where is it from?

> ---
>  drivers/net/wireless/rtlwifi/rtl8723be/sw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
> index 7834ae5..8416362 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
> @@ -92,7 +92,7 @@ int rtl8723be_init_sw_vars(struct ieee80211_hw *hw)
>  	struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
>  
>  	rtl8723be_bt_reg_init(hw);
> -	rtlpci->msi_support = true;
> +	rtlpci->msi_support = false;
>  	rtlpriv->btcoexist.btc_ops = rtl_btc_get_ops_pointer();
>  
>  	rtlpriv->dm.dm_initialgain_enable = 1;

Acked-by: Andy Whitcroft <apw@canonical.com>

Looks ok modulo resolving its provenance.

-apw
Adam Lee - May 16, 2014, 2:43 p.m.
On Fri, May 16, 2014 at 01:51:45PM +0100, Andy Whitcroft wrote:
> On Fri, May 16, 2014 at 12:52:21PM +0800, Adam Lee wrote:
> > BugLink: http://bugs.launchpad.net/bugs/1320070
> > 
> > 94010fa0dd07e8b904e7c6b6589f15573008ab15 ("rtlwifi: add MSI interrupts
> > mode support") introduced MSI interrupts mode support, which seemed
> > safe enough with RTL8188EE and RTL8723BE as RealTek's testing results,
> > but some users reported their RTL8188EE modules could not connect to
> > any wireless network after the MSI mode was enabled by Ubuntu 14.04.
> > 
> > So, let's fallback to pin-based mode until rtlwifi's MSI support get
> > good compatibility.
> > 
> > BugLink: https://bugs.launchpad.net/bugs/1310512
> > Signed-off-by: Adam Lee <adam.lee@canonical.com>
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> > (cherry picked from commit 329d6e299f92a591acb3a80f6d597a5f9dce7e6d)
> 
> Cannot find this commit in linus' tree?  Where is it from?

It's from wireless-next(sorry not marked), should I wait for it to be
merged in Linus's tree?
Tim Gardner - May 19, 2014, 5:24 p.m.

Patch

diff --git a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
index 7834ae5..8416362 100644
--- a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
@@ -92,7 +92,7 @@  int rtl8723be_init_sw_vars(struct ieee80211_hw *hw)
 	struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
 
 	rtl8723be_bt_reg_init(hw);
-	rtlpci->msi_support = true;
+	rtlpci->msi_support = false;
 	rtlpriv->btcoexist.btc_ops = rtl_btc_get_ops_pointer();
 
 	rtlpriv->dm.dm_initialgain_enable = 1;