diff mbox

[net] bonding: fix out of range parameters for bond_intmax_tbl

Message ID 1400153723-8031-1-git-send-email-nikolay@redhat.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Nikolay Aleksandrov May 15, 2014, 11:35 a.m. UTC
I've missed to add a NULL entry to the bond_intmax_tbl when I introduced
it with the conversion of arp_interval so add it now.

CC: Jay Vosburgh <j.vosburgh@gmail.com>
CC: Veaceslav Falico <vfalico@gmail.com>
CC: Andy Gospodarek <andy@greyhouse.net>

Fixes: 7bdb04ed0dbf ("bonding: convert arp_interval to use the new
option API")
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
---
 drivers/net/bonding/bond_options.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Veaceslav Falico May 15, 2014, 11:44 a.m. UTC | #1
On Thu, May 15, 2014 at 01:35:23PM +0200, Nikolay Aleksandrov wrote:
>I've missed to add a NULL entry to the bond_intmax_tbl when I introduced
>it with the conversion of arp_interval so add it now.
>
>CC: Jay Vosburgh <j.vosburgh@gmail.com>
>CC: Veaceslav Falico <vfalico@gmail.com>

Acked-by: Veaceslav Falico <vfalico@gmail.com>

>CC: Andy Gospodarek <andy@greyhouse.net>
>
>Fixes: 7bdb04ed0dbf ("bonding: convert arp_interval to use the new
>option API")
>Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
>---
> drivers/net/bonding/bond_options.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
>index 724e30fa20b9..832070298446 100644
>--- a/drivers/net/bonding/bond_options.c
>+++ b/drivers/net/bonding/bond_options.c
>@@ -125,6 +125,7 @@ static const struct bond_opt_value bond_fail_over_mac_tbl[] = {
> static const struct bond_opt_value bond_intmax_tbl[] = {
> 	{ "off",     0,       BOND_VALFLAG_DEFAULT},
> 	{ "maxval",  INT_MAX, BOND_VALFLAG_MAX},
>+	{ NULL,      -1,      0}
> };
>
> static const struct bond_opt_value bond_lacp_rate_tbl[] = {
>-- 
>1.8.5.3
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller May 16, 2014, 3:37 a.m. UTC | #2
From: Nikolay Aleksandrov <nikolay@redhat.com>
Date: Thu, 15 May 2014 13:35:23 +0200

> I've missed to add a NULL entry to the bond_intmax_tbl when I introduced
> it with the conversion of arp_interval so add it now.
> 
> CC: Jay Vosburgh <j.vosburgh@gmail.com>
> CC: Veaceslav Falico <vfalico@gmail.com>
> CC: Andy Gospodarek <andy@greyhouse.net>
> 
> Fixes: 7bdb04ed0dbf ("bonding: convert arp_interval to use the new option API")
> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
index 724e30fa20b9..832070298446 100644
--- a/drivers/net/bonding/bond_options.c
+++ b/drivers/net/bonding/bond_options.c
@@ -125,6 +125,7 @@  static const struct bond_opt_value bond_fail_over_mac_tbl[] = {
 static const struct bond_opt_value bond_intmax_tbl[] = {
 	{ "off",     0,       BOND_VALFLAG_DEFAULT},
 	{ "maxval",  INT_MAX, BOND_VALFLAG_MAX},
+	{ NULL,      -1,      0}
 };
 
 static const struct bond_opt_value bond_lacp_rate_tbl[] = {