| Message ID | 1400153056-12793-1-git-send-email-wei.liu2@citrix.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 2014-05-15 at 12:24 +0100, Wei Liu wrote: > ... otherwise the frontend will try to send TX event all the time, even > if no progress can be made. The pointer should only be advanced by the > routine that actually processes the ring. Please can you mention that this routing is xenvif_poll. > Reported-by: Jacek Konieczny <jajcus@jajcus.net> > Signed-off-by: Wei Liu <wei.liu2@citrix.com> Other than that small nit: Acked-by: Ian Campbell <ian.campbell@citrix.com> Thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7666540..8e2cbeb 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -658,7 +658,7 @@ void xenvif_check_rx_xenvif(struct xenvif *vif) { int more_to_do; - RING_FINAL_CHECK_FOR_REQUESTS(&vif->tx, more_to_do); + more_to_do = RING_HAS_UNCONSUMED_REQUESTS(&vif->tx); if (more_to_do) napi_schedule(&vif->napi);
... otherwise the frontend will try to send TX event all the time, even if no progress can be made. The pointer should only be advanced by the routine that actually processes the ring. Reported-by: Jacek Konieczny <jajcus@jajcus.net> Signed-off-by: Wei Liu <wei.liu2@citrix.com> Cc: Ian Campbell <ian.campbell@citrix.com> Cc: Paul Durrant <paul.durrant@citrix.com> --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)