diff mbox

net: driver: samsung: keep off in Kconfig by default

Message ID 20140514182416.106B1904@viggo.jf.intel.com
State Rejected, archived
Delegated to: David Miller
Headers show

Commit Message

Dave Hansen May 14, 2014, 6:24 p.m. UTC 
From: Dave Hansen <dave.hansen@linux.intel.com>

These are a pet peeve of mine: Kconfig options that very few
people need turned on, but that default to y.

I know that this doesn't generate any code by itself, but it
does get in the way of every single person that does an
oldconfig.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Siva Reddy Kallam <siva.kallam@samsung.com>
Cc: Vipul Pandya <vipul.pandya@samsung.com>
Cc: Girish K S <ks.giri@samsung.com>
Cc: Joe Perches <joe@perches.com>
Cc: Byungho An <bh74.an@samsung.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
---

 b/drivers/net/ethernet/samsung/Kconfig |    1 -
 1 file changed, 1 deletion(-)

Comments

David Miller May 14, 2014, 7:05 p.m. UTC | #1 
From: Dave Hansen <dave@sr71.net>
Date: Wed, 14 May 2014 11:24:16 -0700

> 
> From: Dave Hansen <dave.hansen@linux.intel.com>
> 
> These are a pet peeve of mine: Kconfig options that very few
> people need turned on, but that default to y.
> 
> I know that this doesn't generate any code by itself, but it
> does get in the way of every single person that does an
> oldconfig.
> 
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>

The general policy we have is that VENDOR guards are on by default.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -puN drivers/net/ethernet/samsung/Kconfig~turn-off-samsung-on-by-default drivers/net/ethernet/samsung/Kconfig
--- a/drivers/net/ethernet/samsung/Kconfig~turn-off-samsung-on-by-default	2014-05-14 11:17:06.213259966 -0700
+++ b/drivers/net/ethernet/samsung/Kconfig	2014-05-14 11:17:14.440628851 -0700
@@ -4,7 +4,6 @@ 
 
 config NET_VENDOR_SAMSUNG
 	bool "Samsung Ethernet devices"
-	default y
 	---help---
 	  If you have a network (Ethernet) chipset belonging to this class,
 	  say Y.