Patchwork [lts-backport-quantal,lts-backport-raring,SRU,1/1] rtlwifi: Remove setting of link_state to MAC80211_LINKED

login
register
mail settings
Submitter Joseph Salisbury
Date May 14, 2014, 2:49 p.m.
Message ID <1c4a308126f3cd29e0f23083a2401f6c64d58790.1400009226.git.joseph.salisbury@canonical.com>
Download mbox | patch
Permalink /patch/348805/
State New
Headers show

Comments

Joseph Salisbury - May 14, 2014, 2:49 p.m.
From: Larry Finger <Larry.Finger@lwfinger.net>

BugLink: http://bugs.launchpad.net/bugs/1289429

Fix from Larry Finger for a problem that shows up between 3.8.0-36 and 3.8.0-37.   There is no real understanding as to why this line of code does not cause any problems with later kernel versions, but it does here. In addition, we have not had any reports of problems with other users. That suggests some kind of bad interaction with the user-space network control components in 12.04.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
---
 drivers/net/wireless/rtlwifi/core.c | 1 -
 1 file changed, 1 deletion(-)
Tim Gardner - May 14, 2014, 3:13 p.m.

Brad Figg - May 14, 2014, 3:20 p.m.
On 05/14/2014 07:49 AM, Joseph Salisbury wrote:
> From: Larry Finger <Larry.Finger@lwfinger.net>
> 
> BugLink: http://bugs.launchpad.net/bugs/1289429
> 
> Fix from Larry Finger for a problem that shows up between 3.8.0-36 and 3.8.0-37.   There is no real understanding as to why this line of code does not cause any problems with later kernel versions, but it does here. In addition, we have not had any reports of problems with other users. That suggests some kind of bad interaction with the user-space network control components in 12.04.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> ---
>  drivers/net/wireless/rtlwifi/core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/rtlwifi/core.c b/drivers/net/wireless/rtlwifi/core.c
> index 1eb562a..77e4a58 100644
> --- a/drivers/net/wireless/rtlwifi/core.c
> +++ b/drivers/net/wireless/rtlwifi/core.c
> @@ -187,7 +187,6 @@ static int rtl_op_add_interface(struct ieee80211_hw *hw,
>  					rtlpriv->cfg->maps
>  					[RTL_IBSS_INT_MASKS]);
>  		}
> -		mac->link_state = MAC80211_LINKED;
>  		break;
>  	case NL80211_IFTYPE_ADHOC:
>  		RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD,
>
Seth Forshee - May 14, 2014, 3:21 p.m.
On Wed, May 14, 2014 at 10:49:17AM -0400, Joseph Salisbury wrote:
> From: Larry Finger <Larry.Finger@lwfinger.net>
> 
> BugLink: http://bugs.launchpad.net/bugs/1289429
> 
> Fix from Larry Finger for a problem that shows up between 3.8.0-36 and 3.8.0-37.   There is no real understanding as to why this line of code does not cause any problems with later kernel versions, but it does here. In addition, we have not had any reports of problems with other users. That suggests some kind of bad interaction with the user-space network control components in 12.04.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> ---
>  drivers/net/wireless/rtlwifi/core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/rtlwifi/core.c b/drivers/net/wireless/rtlwifi/core.c
> index 1eb562a..77e4a58 100644
> --- a/drivers/net/wireless/rtlwifi/core.c
> +++ b/drivers/net/wireless/rtlwifi/core.c
> @@ -187,7 +187,6 @@ static int rtl_op_add_interface(struct ieee80211_hw *hw,
>  					rtlpriv->cfg->maps
>  					[RTL_IBSS_INT_MASKS]);
>  		}
> -		mac->link_state = MAC80211_LINKED;
>  		break;
>  	case NL80211_IFTYPE_ADHOC:
>  		RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD,
> -- 
> 1.9.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Patch

diff --git a/drivers/net/wireless/rtlwifi/core.c b/drivers/net/wireless/rtlwifi/core.c
index 1eb562a..77e4a58 100644
--- a/drivers/net/wireless/rtlwifi/core.c
+++ b/drivers/net/wireless/rtlwifi/core.c
@@ -187,7 +187,6 @@  static int rtl_op_add_interface(struct ieee80211_hw *hw,
 					rtlpriv->cfg->maps
 					[RTL_IBSS_INT_MASKS]);
 		}
-		mac->link_state = MAC80211_LINKED;
 		break;
 	case NL80211_IFTYPE_ADHOC:
 		RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD,