diff mbox

[v3.2,09/31] qmp: improve error reporting for -object and object-add

Message ID 4e4420c483f45dbaa20b914b1a63daa9ec396b8c.1400049817.git.hutao@cn.fujitsu.com
State New
Headers show

Commit Message

Hu Tao May 14, 2014, 9:43 a.m. UTC 
From: Paolo Bonzini <pbonzini@redhat.com>

Use QERR_INVALID_PARAMETER_VALUE for consistency.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
---
 qmp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Eduardo Habkost May 14, 2014, 8:13 p.m. UTC | #1 
On Wed, May 14, 2014 at 05:43:13PM +0800, Hu Tao wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> Use QERR_INVALID_PARAMETER_VALUE for consistency.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
diff mbox

Patch

diff --git a/qmp.c b/qmp.c
index b722dbe..cef60fb 100644
--- a/qmp.c
+++ b/qmp.c
@@ -540,7 +540,8 @@  void object_add(const char *type, const char *id, const QDict *qdict,
 
     klass = object_class_by_name(type);
     if (!klass) {
-        error_setg(errp, "invalid class name");
+        error_set(errp, QERR_INVALID_PARAMETER_VALUE,
+                  "qom-type", "a valid class name");
         return;
     }