From patchwork Fri Oct 2 12:06:47 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Bolle X-Patchwork-Id: 34842 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 73A73B7BDB for ; Fri, 2 Oct 2009 22:07:45 +1000 (EST) Received: from localhost ([127.0.0.1]:40175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtgvF-0007zB-NF for incoming@patchwork.ozlabs.org; Fri, 02 Oct 2009 08:07:41 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mtgua-0007ug-63 for qemu-devel@nongnu.org; Fri, 02 Oct 2009 08:07:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MtguV-0007rH-6j for qemu-devel@nongnu.org; Fri, 02 Oct 2009 08:06:59 -0400 Received: from [199.232.76.173] (port=44290 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MtguV-0007qp-1K for qemu-devel@nongnu.org; Fri, 02 Oct 2009 08:06:55 -0400 Received: from smtp-out2.tiscali.nl ([195.241.79.177]:39349) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MtguU-0001sg-9E for qemu-devel@nongnu.org; Fri, 02 Oct 2009 08:06:54 -0400 Received: from [212.123.169.34] (helo=[192.168.1.61]) by smtp-out2.tiscali.nl with esmtp (Exim) (envelope-from ) id 1MtguR-00027U-EI for qemu-devel@nongnu.org; Fri, 02 Oct 2009 14:06:51 +0200 From: Paul Bolle To: qemu-devel@nongnu.org Date: Fri, 02 Oct 2009 14:06:47 +0200 Message-Id: <1254485207.1738.11.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.28.0 (2.28.0-1.fc12) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: [Qemu-devel] [PATCH][TRIVIAL] linux-user: fix "#if 0"'d printf() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Make an "#if 0"'d printf() in load_elf_binary(), probably left to aid in debugging, reflect what the actual code does. The current printf() will only confuse those who "#if 1" it (it certainly confused me enough to write this trivial patch). Signed-off-by: Paul Bolle --- bsd-user/elfload.c could use a similar fix if this is accepted. linux-user/elfload.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 07277a6..62a3f2a 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -1454,7 +1454,7 @@ int load_elf_binary(struct linux_binprm * bprm, struct target_pt_regs * regs, } #if 0 - printf("Using ELF interpreter %s\n", elf_interpreter); + printf("Using ELF interpreter %s\n", path(elf_interpreter)); #endif if (retval >= 0) { retval = open(path(elf_interpreter), O_RDONLY);