| Message ID | 1399964572-5376-9-git-send-email-marc.mari.barcelo@gmail.com |
|---|---|
| State | New |
| Headers | show |
El Tue, 13 May 2014 09:02:44 +0200 Marc Marí <marc.mari.barcelo@gmail.com> escribió: > diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c > index 6f0a4d2..302f2bf 100644 > --- a/hw/tpm/tpm_tis.c > +++ b/hw/tpm/tpm_tis.c > @@ -30,16 +30,16 @@ > #include "qemu-common.h" > #include "qemu/main-loop.h" > > -/*#define DEBUG_TIS */ > +/*#define DEBUG_TIS*/ > > #ifdef DEBUG_TIS > -#define DPRINTF(fmt, ...) \ > - do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0) > +#define DEBUG_TIS_ENABLED 1 > #else > -#define DPRINTF(fmt, ...) \ > - do { } while (0) > +#define DEBUG_TIS_ENABLED 0 > #endif > > +#define DPRINTF(fmt, ...) QEMU_DPRINTF(DEBUG_TIS_ENABLED, "tpm-tis", > fmt, ## __VA_ARGS__) + > /* whether the STS interrupt is supported */ > #define RAISE_STS_IRQ > I saw that later in that file there are some DPRINTF that do not add a \n at the end (for example in L.141). As this codes are already in a #ifdef DEBUG_TIS, some of this DPRINTFs can be changed to fprintf in next versions. Marc
diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough.c index 56e9e0f..673ab0e 100644 --- a/hw/tpm/tpm_passthrough.c +++ b/hw/tpm/tpm_passthrough.c @@ -37,13 +37,13 @@ /* #define DEBUG_TPM */ #ifdef DEBUG_TPM -#define DPRINTF(fmt, ...) \ - do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0) +#define DEBUG_TPM_ENABLED 1 #else -#define DPRINTF(fmt, ...) \ - do { } while (0) +#define DEBUG_TPM_ENABLED 0 #endif +#define DPRINTF(fmt, ...) QEMU_DPRINTF(DEBUG_TPM_ENABLED, "tpm-passthrough", fmt, ## __VA_ARGS__) + #define TYPE_TPM_PASSTHROUGH "tpm-passthrough" #define TPM_PASSTHROUGH(obj) \ OBJECT_CHECK(TPMPassthruState, (obj), TYPE_TPM_PASSTHROUGH) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index 6f0a4d2..302f2bf 100644 --- a/hw/tpm/tpm_tis.c +++ b/hw/tpm/tpm_tis.c @@ -30,16 +30,16 @@ #include "qemu-common.h" #include "qemu/main-loop.h" -/*#define DEBUG_TIS */ +/*#define DEBUG_TIS*/ #ifdef DEBUG_TIS -#define DPRINTF(fmt, ...) \ - do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0) +#define DEBUG_TIS_ENABLED 1 #else -#define DPRINTF(fmt, ...) \ - do { } while (0) +#define DEBUG_TIS_ENABLED 0 #endif +#define DPRINTF(fmt, ...) QEMU_DPRINTF(DEBUG_TIS_ENABLED, "tpm-tis", fmt, ## __VA_ARGS__) + /* whether the STS interrupt is supported */ #define RAISE_STS_IRQ
Modify debug macros to have the same format through the codebase and use regular ifs instead of ifdef. As the debug printf is always put in code, some casting had to be added to avoid warnings treated as errors at compile time. Signed-off-by: Marc Marí <marc.mari.barcelo@gmail.com> --- hw/tpm/tpm_passthrough.c | 8 ++++---- hw/tpm/tpm_tis.c | 10 +++++----- 2 files changed, 9 insertions(+), 9 deletions(-)