| Message ID | 1399941203-8282-2-git-send-email-cody@linux.vnet.ibm.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Cody, On Mon, May 12, 2014 at 05:33:16PM -0700, Cody P Schafer wrote: > To prep for powerpc64le, we also disable gdb prior to 7.7.1 on > powerpc64le. > > The default gdb on powerpc64le is set to 7.7. > The default gdb on anything not special cased is adjusted from 7.5 to > 7.6. This patch should be split into two IMO. One patch adding gdb 7.6 and making it default, and the other adding 7.7 for powerpc64le. This would ease somewhat the pain of reverting the 7.6 bump in case it turns out to be not a good idea. Thanks, baruch > Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com> > --- > package/gdb/Config.in.host | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/package/gdb/Config.in.host b/package/gdb/Config.in.host > index e853469..16a7291 100644 > --- a/package/gdb/Config.in.host > +++ b/package/gdb/Config.in.host > @@ -19,7 +19,8 @@ choice > depends on !BR2_microblaze > default BR2_GDB_VERSION_6_6 if BR2_bfin > default BR2_GDB_VERSION_6_7_1_AVR32_2_1_5 if BR2_avr32 > - default BR2_GDB_VERSION_7_5 > + default BR2_GDB_VERSION_7_7 if BR2_powerpc64le > + default BR2_GDB_VERSION_7_6 > help > Select the version of gdb you wish to use. > > @@ -33,10 +34,18 @@ choice > > config BR2_GDB_VERSION_7_4 > bool "gdb 7.4.x" > - depends on !BR2_bfin > + depends on !BR2_bfin && !BR2_powerpc64le > > config BR2_GDB_VERSION_7_5 > bool "gdb 7.5.x" > + depends on !BR2_bfin && !BR2_powerpc64le > + > + config BR2_GDB_VERSION_7_6 > + bool "gdb 7.6.x" > + depends on !BR2_bfin && !BR2_powerpc64le > + > + config BR2_GDB_VERSION_7_7 > + bool "gdb 7.7.x" > depends on !BR2_bfin > > endchoice > @@ -54,4 +63,6 @@ config BR2_GDB_VERSION > default "arc-4.8-R3" if BR2_arc > default "6be65fb56ea6694a9260733a536a023a1e2d4d57" if BR2_microblaze > default "7.4.1" if BR2_GDB_VERSION_7_4 > - default "7.5.1" if BR2_GDB_VERSION_7_5 || !BR2_PACKAGE_HOST_GDB > + default "7.5.1" if BR2_GDB_VERSION_7_5 > + default "7.6.2" if BR2_GDB_VERSION_7_6 || !BR2_PACKAGE_HOST_GDB > + default "7.7.1" if BR2_GDB_VERSION_7_7 || BR2_powerpc64le > -- > 1.9.3
On 05/12/2014 08:50 PM, Baruch Siach wrote: > Hi Cody, > > On Mon, May 12, 2014 at 05:33:16PM -0700, Cody P Schafer wrote: >> To prep for powerpc64le, we also disable gdb prior to 7.7.1 on >> powerpc64le. >> >> The default gdb on powerpc64le is set to 7.7. >> The default gdb on anything not special cased is adjusted from 7.5 to >> 7.6. > > This patch should be split into two IMO. One patch adding gdb 7.6 and making > it default, and the other adding 7.7 for powerpc64le. This would ease somewhat > the pain of reverting the 7.6 bump in case it turns out to be not a good idea. > To make it even easier, I just made the default change a seperate patch. Take a look at v4.
diff --git a/package/gdb/Config.in.host b/package/gdb/Config.in.host index e853469..16a7291 100644 --- a/package/gdb/Config.in.host +++ b/package/gdb/Config.in.host @@ -19,7 +19,8 @@ choice depends on !BR2_microblaze default BR2_GDB_VERSION_6_6 if BR2_bfin default BR2_GDB_VERSION_6_7_1_AVR32_2_1_5 if BR2_avr32 - default BR2_GDB_VERSION_7_5 + default BR2_GDB_VERSION_7_7 if BR2_powerpc64le + default BR2_GDB_VERSION_7_6 help Select the version of gdb you wish to use. @@ -33,10 +34,18 @@ choice config BR2_GDB_VERSION_7_4 bool "gdb 7.4.x" - depends on !BR2_bfin + depends on !BR2_bfin && !BR2_powerpc64le config BR2_GDB_VERSION_7_5 bool "gdb 7.5.x" + depends on !BR2_bfin && !BR2_powerpc64le + + config BR2_GDB_VERSION_7_6 + bool "gdb 7.6.x" + depends on !BR2_bfin && !BR2_powerpc64le + + config BR2_GDB_VERSION_7_7 + bool "gdb 7.7.x" depends on !BR2_bfin endchoice @@ -54,4 +63,6 @@ config BR2_GDB_VERSION default "arc-4.8-R3" if BR2_arc default "6be65fb56ea6694a9260733a536a023a1e2d4d57" if BR2_microblaze default "7.4.1" if BR2_GDB_VERSION_7_4 - default "7.5.1" if BR2_GDB_VERSION_7_5 || !BR2_PACKAGE_HOST_GDB + default "7.5.1" if BR2_GDB_VERSION_7_5 + default "7.6.2" if BR2_GDB_VERSION_7_6 || !BR2_PACKAGE_HOST_GDB + default "7.7.1" if BR2_GDB_VERSION_7_7 || BR2_powerpc64le
To prep for powerpc64le, we also disable gdb prior to 7.7.1 on powerpc64le. The default gdb on powerpc64le is set to 7.7. The default gdb on anything not special cased is adjusted from 7.5 to 7.6. Signed-off-by: Cody P Schafer <cody@linux.vnet.ibm.com> --- package/gdb/Config.in.host | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-)