diff mbox

libbluray: needs dynamic library support

Message ID 1399919032-9512-1-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Commit 952f3dfb54d3424225edaa78fe6b107f045aa29b
Headers show

Commit Message

Thomas Petazzoni May 12, 2014, 6:23 p.m. UTC
The dependency is propagated to XBMC, even though XBMC currently
requires an (e)glibc toolchain, which always have dynamic library
support. This is just in case one day XBMC can be built against
uClibc.

Fixes:

  http://autobuild.buildroot.org/results/3fa/3fae35ebcf14d6f38284d8318f61f9b99998794c/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/libbluray/Config.in | 4 +++-
 package/xbmc/Config.in      | 4 ++++
 2 files changed, 7 insertions(+), 1 deletion(-)

Comments

Peter Korsgaard May 12, 2014, 8:19 p.m. UTC | #1
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > The dependency is propagated to XBMC, even though XBMC currently
 > requires an (e)glibc toolchain, which always have dynamic library
 > support. This is just in case one day XBMC can be built against
 > uClibc.

 > Fixes:

 >   http://autobuild.buildroot.org/results/3fa/3fae35ebcf14d6f38284d8318f61f9b99998794c/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/libbluray/Config.in b/package/libbluray/Config.in
index 2571f5c..e174773 100644
--- a/package/libbluray/Config.in
+++ b/package/libbluray/Config.in
@@ -1,10 +1,12 @@ 
 config BR2_PACKAGE_LIBBLURAY
 	bool "libbluray"
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_PREFER_STATIC_LIB
 	help
 	  libbluray is a client library for accessing bluray disks.
 
 	  http://www.videolan.org/developers/libbluray.html
 
-comment "libbluray needs a toolchain w/ threads"
+comment "libbluray needs a toolchain w/ threads, dynamic library"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_PREFER_STATIC_LIB
diff --git a/package/xbmc/Config.in b/package/xbmc/Config.in
index ed8872b..1e2f932 100644
--- a/package/xbmc/Config.in
+++ b/package/xbmc/Config.in
@@ -85,10 +85,14 @@  config BR2_PACKAGE_XBMC_DBUS
 config BR2_PACKAGE_XBMC_LIBBLURAY
 	bool "blu-ray"
 	select BR2_PACKAGE_LIBBLURAY
+	depends on !BR2_PREFER_STATIC_LIB
 	help
 	  Enable Blu-ray input support.
 	  Select this if you want to play back Blu-ray content.
 
+comment "libbluray support needs a toolchain w/ dynamic library"
+	depends on BR2_PREFER_STATIC_LIB
+
 config BR2_PACKAGE_XBMC_LIBCEC
 	bool "hdmi cec"
 	depends on !BR2_PREFER_STATIC_LIB # libcec