| Message ID | 4AC58C46.8080408@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Eric Dumazet a écrit : > Here is a followup on this area, thanks. > > [RFC] af_packet: fill skb->mark at xmit > > skb->mark may be used by classifiers, so fill it in case user > set a SO_MARK option on socket. > Maybe a more generic way to handle this for various protocols would be to fill skb->mark in sock_alloc_send_pskb() -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Cool! As I've already pointed out in a post 2 or so weeks ago, we need the exact same treatment in a ton of places throughout the code (tcp, ipv6, decnet, etc...). Maybe it would make more sense to create some constructor-like functions for the flowi struct? On Thu, Oct 1, 2009 at 23:08, Eric Dumazet <eric.dumazet@gmail.com> wrote: > Eric Dumazet a écrit : >> Here is a followup on this area, thanks. >> >> [RFC] af_packet: fill skb->mark at xmit >> >> skb->mark may be used by classifiers, so fill it in case user >> set a SO_MARK option on socket. >> > > Maybe a more generic way to handle this for various protocols > would be to fill skb->mark in sock_alloc_send_pskb() > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Fri, 02 Oct 2009 07:14:46 +0200 > Here is a followup on this area, thanks. > > [RFC] af_packet: fill skb->mark at xmit > > skb->mark may be used by classifiers, so fill it in case user > set a SO_MARK option on socket. > > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Looks fine, applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index d7ecca0..610f150 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -490,6 +490,7 @@ static int packet_sendmsg_spkt(struct kiocb *iocb, struct socket *sock, skb->protocol = proto; skb->dev = dev; skb->priority = sk->sk_priority; + skb->mark = sk->sk_mark; if (err) goto out_free; @@ -856,6 +857,7 @@ static int tpacket_fill_skb(struct packet_sock *po, struct sk_buff *skb, skb->protocol = proto; skb->dev = dev; skb->priority = po->sk.sk_priority; + skb->mark = po->sk.sk_mark; skb_shinfo(skb)->destructor_arg = ph.raw; switch (po->tp_version) { @@ -1125,6 +1127,7 @@ static int packet_snd(struct socket *sock, skb->protocol = proto; skb->dev = dev; skb->priority = sk->sk_priority; + skb->mark = sk->sk_mark; /* * Now send it
Here is a followup on this area, thanks. [RFC] af_packet: fill skb->mark at xmit skb->mark may be used by classifiers, so fill it in case user set a SO_MARK option on socket. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- net/packet/af_packet.c | 3 +++ 1 file changed, 3 insertions(+) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html