| Message ID | 1399899388-13101-1-git-send-email-antoine.tenart@free-electrons.com |
|---|---|
| State | New |
| Headers | show |
On 12/05/14 14:56, Antoine Ténart wrote: > The phys array is of size EXYNOS_MIPI_PHYS_NUM. Trying to access the > index EXYNOS_MIPI_PHYS_NUM should return an error. > > Fixes: 069d2e26e9d6 "phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs" > > Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com> Thanks for the fix, Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > drivers/phy/phy-exynos-mipi-video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c > index 7f139326a642..ff026689358c 100644 > --- a/drivers/phy/phy-exynos-mipi-video.c > +++ b/drivers/phy/phy-exynos-mipi-video.c > @@ -101,7 +101,7 @@ static struct phy *exynos_mipi_video_phy_xlate(struct device *dev, > { > struct exynos_mipi_video_phy *state = dev_get_drvdata(dev); > > - if (WARN_ON(args->args[0] > EXYNOS_MIPI_PHYS_NUM)) > + if (WARN_ON(args->args[0] >= EXYNOS_MIPI_PHYS_NUM)) > return ERR_PTR(-ENODEV); > > return state->phys[args->args[0]].phy;
diff --git a/drivers/phy/phy-exynos-mipi-video.c b/drivers/phy/phy-exynos-mipi-video.c index 7f139326a642..ff026689358c 100644 --- a/drivers/phy/phy-exynos-mipi-video.c +++ b/drivers/phy/phy-exynos-mipi-video.c @@ -101,7 +101,7 @@ static struct phy *exynos_mipi_video_phy_xlate(struct device *dev, { struct exynos_mipi_video_phy *state = dev_get_drvdata(dev); - if (WARN_ON(args->args[0] > EXYNOS_MIPI_PHYS_NUM)) + if (WARN_ON(args->args[0] >= EXYNOS_MIPI_PHYS_NUM)) return ERR_PTR(-ENODEV); return state->phys[args->args[0]].phy;
The phys array is of size EXYNOS_MIPI_PHYS_NUM. Trying to access the index EXYNOS_MIPI_PHYS_NUM should return an error. Fixes: 069d2e26e9d6 "phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs" Signed-off-by: Antoine Ténart <antoine.tenart@free-electrons.com> --- drivers/phy/phy-exynos-mipi-video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)