Patchwork [21/30] netfilter: bridge: refcount fix

mail settings
Date Oct. 1, 2009, 11:31 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/34795/
State Not Applicable
Delegated to: David Miller
Headers show

Comments - Oct. 1, 2009, 11:31 p.m.
2.6.30-stable review patch.  If anyone has any objections, please let us know.

From: Patrick McHardy <>

netfilter: bridge: refcount fix

Upstream commit f3abc9b9:

commit f216f082b2b37c4943f1e7c393e2786648d48f6f
([NETFILTER]: bridge netfilter: deal with martians correctly)
added a refcount leak on in_dev.

Instead of using in_dev_get(), we can use __in_dev_get_rcu(),
as netfilter hooks are running under rcu_read_lock(), as pointed
by Patrick.

Signed-off-by: Eric Dumazet <>
Signed-off-by: Patrick McHardy <>
Signed-off-by: Greg Kroah-Hartman <>

 net/bridge/br_netfilter.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at


--- a/net/bridge/br_netfilter.c
+++ b/net/bridge/br_netfilter.c
@@ -357,7 +357,7 @@  static int br_nf_pre_routing_finish(stru
 				.proto = 0,
-			struct in_device *in_dev = in_dev_get(dev);
+			struct in_device *in_dev = __in_dev_get_rcu(dev);
 			/* If err equals -EHOSTUNREACH the error is due to a
 			 * martian destination or due to the fact that