diff mbox

[4/4] sysstat: fix passing CFLAGS to make

Message ID 1399865226-7054-5-git-send-email-jcmvbkbc@gmail.com
State Accepted
Commit bb7271b9fe7e4fc3611e9ae0f3cf3171149a8ec0
Headers show

Commit Message

Max Filippov May 12, 2014, 3:27 a.m. UTC 
SYSSTAT_MAKE_OPT is a string used to pass options to make, '+=' operator
doesn't have any special meaning inside it, so CFLAGS+=... is passed to
shell, overwriting previous CFLAGS value.

Replace CFLAGS+="..." with CFLAGS="$(TARGET_CFLAGS) ...".

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 package/sysstat/sysstat.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Thomas Petazzoni May 12, 2014, 5:51 p.m. UTC | #1 
Dear Max Filippov,

On Mon, 12 May 2014 07:27:06 +0400, Max Filippov wrote:
> SYSSTAT_MAKE_OPT is a string used to pass options to make, '+=' operator
> doesn't have any special meaning inside it, so CFLAGS+=... is passed to
> shell, overwriting previous CFLAGS value.
> 
> Replace CFLAGS+="..." with CFLAGS="$(TARGET_CFLAGS) ...".
> 
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  package/sysstat/sysstat.mk |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
diff mbox

Patch

diff --git a/package/sysstat/sysstat.mk b/package/sysstat/sysstat.mk
index d3d7519..23486b6 100644
--- a/package/sysstat/sysstat.mk
+++ b/package/sysstat/sysstat.mk
@@ -14,7 +14,7 @@  SYSSTAT_LICENSE_FILES = COPYING
 
 ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y)
 SYSSTAT_DEPENDENCIES += gettext
-SYSSTAT_MAKE_OPT += CFLAGS+=-lintl
+SYSSTAT_MAKE_OPT += CFLAGS="$(TARGET_CFLAGS) -lintl"
 endif
 
 # The isag tool is a post processing script that depends on tcl/tk