diff mbox

[1/4] sqlcipher: fix passing CFLAGS/LDFLAGS to configure

Message ID 1399865226-7054-2-git-send-email-jcmvbkbc@gmail.com
State Accepted
Commit 09322f456b7d00989a6a340a377096499c11e1db
Headers show

Commit Message

Max Filippov May 12, 2014, 3:27 a.m. UTC
SQLCIPHER_CONF_ENV is a string used to pass environment variables to the
confgiure script, '+=' operator doesn't have any special meaning inside
it, so CFLAGS+=... is passed to shell, overwriting previous CFLAGS
value. Replace CFLAGS+="..." with CFLAGS="$(TARGET_CFLAGS) ...".

Fixes:
  http://autobuild.buildroot.net/results/dbf/dbf947ad6442fa8e57201ffcc96871361bf39ad7/

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 package/sqlcipher/sqlcipher.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni May 12, 2014, 5:50 p.m. UTC | #1
Dear Max Filippov,

On Mon, 12 May 2014 07:27:03 +0400, Max Filippov wrote:
> SQLCIPHER_CONF_ENV is a string used to pass environment variables to the
> confgiure script, '+=' operator doesn't have any special meaning inside
> it, so CFLAGS+=... is passed to shell, overwriting previous CFLAGS
> value. Replace CFLAGS+="..." with CFLAGS="$(TARGET_CFLAGS) ...".
> 
> Fixes:
>   http://autobuild.buildroot.net/results/dbf/dbf947ad6442fa8e57201ffcc96871361bf39ad7/
> 
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
>  package/sqlcipher/sqlcipher.mk |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
diff mbox

Patch

diff --git a/package/sqlcipher/sqlcipher.mk b/package/sqlcipher/sqlcipher.mk
index 6130870..bae59bb 100644
--- a/package/sqlcipher/sqlcipher.mk
+++ b/package/sqlcipher/sqlcipher.mk
@@ -10,8 +10,8 @@  SQLCIPHER_DEPENDENCIES = openssl host-tcl
 SQLCIPHER_INSTALL_STAGING = YES
 
 SQLCIPHER_CONF_ENV = \
-	CFLAGS+=" $(SQLCIPHER_CFLAGS)" \
-	LDFLAGS+=" $(SQLCIPHER_LDFLAGS)" \
+	CFLAGS="$(TARGET_CFLAGS) $(SQLCIPHER_CFLAGS)" \
+	LDFLAGS="$(TARGET_LDFLAGS) $(SQLCIPHER_LDFLAGS)" \
 	TCLSH_CMD=$(HOST_DIR)/usr/bin/tclsh$(TCL_VERSION_MAJOR)
 
 SQLCIPHER_CONF_OPT = \