diff mbox

[16/17] nsdbc: Fix missing break

Message ID 20140511213019.13852.28914.stgit@seurat.1015granger.net
State Accepted
Headers show

Commit Message

Chuck Lever May 11, 2014, 9:30 p.m. UTC 
Avoid using fallthrough logic in switch statements.

Fixes: 0520ee7207f9ba027c845cb33606a3c901ecd811
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 src/nsdbc/nsdb-create-fsl.c  |    4 +++-
 src/nsdbc/nsdb-create-fsn.c  |    4 +++-
 src/nsdbc/nsdb-delete-fsl.c  |    4 +++-
 src/nsdbc/nsdb-delete-fsn.c  |    4 +++-
 src/nsdbc/nsdb-delete-nsdb.c |    4 +++-
 src/nsdbc/nsdb-describe.c    |    4 +++-
 src/nsdbc/nsdb-list.c        |    4 +++-
 src/nsdbc/nsdb-nces.c        |    4 +++-
 src/nsdbc/nsdb-remove-nci.c  |    4 +++-
 src/nsdbc/nsdb-resolve-fsn.c |    4 +++-
 src/nsdbc/nsdb-simple-nce.c  |    4 +++-
 src/nsdbc/nsdb-update-fsl.c  |    4 +++-
 src/nsdbc/nsdb-update-nci.c  |    4 +++-
 13 files changed, 39 insertions(+), 13 deletions(-)
diff mbox

Patch

diff --git a/src/nsdbc/nsdb-create-fsl.c b/src/nsdbc/nsdb-create-fsl.c
index cf39f46..577cc2a 100644
--- a/src/nsdbc/nsdb-create-fsl.c
+++ b/src/nsdbc/nsdb-create-fsl.c
@@ -160,10 +160,12 @@  main(int argc, char **argv)
 				nsdb_create_fsl_usage(progname);
 			}
 			break;
+		case '?':
+			nsdb_create_fsl_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_create_fsl_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-create-fsn.c b/src/nsdbc/nsdb-create-fsn.c
index 870984d..e32bbbb 100644
--- a/src/nsdbc/nsdb-create-fsn.c
+++ b/src/nsdbc/nsdb-create-fsn.c
@@ -170,10 +170,12 @@  main(int argc, char **argv)
 			}
 			ttl = (unsigned int)tmp;
 			break;
+		case '?':
+			nsdb_create_fsn_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_create_fsn_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-delete-fsl.c b/src/nsdbc/nsdb-delete-fsl.c
index ce33919..46976a5 100644
--- a/src/nsdbc/nsdb-delete-fsl.c
+++ b/src/nsdbc/nsdb-delete-fsl.c
@@ -151,10 +151,12 @@  main(int argc, char **argv)
 				nsdb_delete_fsl_usage(progname);
 			}
 			break;
+		case '?':
+			nsdb_delete_fsl_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_delete_fsl_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-delete-fsn.c b/src/nsdbc/nsdb-delete-fsn.c
index 789216e..c592963 100644
--- a/src/nsdbc/nsdb-delete-fsn.c
+++ b/src/nsdbc/nsdb-delete-fsn.c
@@ -153,10 +153,12 @@  main(int argc, char **argv)
 		case 'y':
 			leave_fsn = true;
 			break;
+		case '?':
+			nsdb_delete_fsn_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_delete_fsn_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-delete-nsdb.c b/src/nsdbc/nsdb-delete-nsdb.c
index 1b51684..f5898f8 100644
--- a/src/nsdbc/nsdb-delete-nsdb.c
+++ b/src/nsdbc/nsdb-delete-nsdb.c
@@ -137,10 +137,12 @@  main(int argc, char **argv)
 				nsdb_delete_nsdb_usage(progname);
 			}
 			break;
+		case '?':
+			nsdb_delete_nsdb_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_delete_nsdb_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-describe.c b/src/nsdbc/nsdb-describe.c
index 3b46dec..dfde4e9 100644
--- a/src/nsdbc/nsdb-describe.c
+++ b/src/nsdbc/nsdb-describe.c
@@ -153,10 +153,12 @@  main(int argc, char **argv)
 		case 'y':
 			delete = true;
 			break;
+		case '?':
+			nsdb_describe_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_describe_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-list.c b/src/nsdbc/nsdb-list.c
index a24d133..6e22a2a 100644
--- a/src/nsdbc/nsdb-list.c
+++ b/src/nsdbc/nsdb-list.c
@@ -324,10 +324,12 @@  main(int argc, char **argv)
 				nsdb_list_usage(progname);
 			}
 			break;
+		case '?':
+			nsdb_list_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_list_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-nces.c b/src/nsdbc/nsdb-nces.c
index 1b08ccc..fdb7c8e 100644
--- a/src/nsdbc/nsdb-nces.c
+++ b/src/nsdbc/nsdb-nces.c
@@ -134,10 +134,12 @@  main(int argc, char **argv)
 				nsdb_nces_usage(progname);
 			}
 			break;
+		case '?':
+			nsdb_nces_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_nces_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-remove-nci.c b/src/nsdbc/nsdb-remove-nci.c
index d98410d..aef43e9 100644
--- a/src/nsdbc/nsdb-remove-nci.c
+++ b/src/nsdbc/nsdb-remove-nci.c
@@ -142,10 +142,12 @@  main(int argc, char **argv)
 				nsdb_remove_nci_usage(progname);
 			}
 			break;
+		case '?':
+			nsdb_remove_nci_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_remove_nci_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-resolve-fsn.c b/src/nsdbc/nsdb-resolve-fsn.c
index ed8549d..ea2c7fd 100644
--- a/src/nsdbc/nsdb-resolve-fsn.c
+++ b/src/nsdbc/nsdb-resolve-fsn.c
@@ -292,10 +292,12 @@  main(int argc, char **argv)
 				nsdb_resolve_fsn_usage(progname);
 			}
 			break;
+		case '?':
+			nsdb_resolve_fsn_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_resolve_fsn_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-simple-nce.c b/src/nsdbc/nsdb-simple-nce.c
index 4eba7b1..0682d6b 100644
--- a/src/nsdbc/nsdb-simple-nce.c
+++ b/src/nsdbc/nsdb-simple-nce.c
@@ -137,10 +137,12 @@  main(int argc, char **argv)
 				nsdb_simple_nce_usage(progname);
 			}
 			break;
+		case '?':
+			nsdb_simple_nce_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_simple_nce_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-update-fsl.c b/src/nsdbc/nsdb-update-fsl.c
index fb7cfcc..83d2712 100644
--- a/src/nsdbc/nsdb-update-fsl.c
+++ b/src/nsdbc/nsdb-update-fsl.c
@@ -157,10 +157,12 @@  main(int argc, char **argv)
 		case 'v':
 			value = optarg;
 			break;
+		case '?':
+			nsdb_update_fsl_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_update_fsl_usage(progname);
 		}
 	}
diff --git a/src/nsdbc/nsdb-update-nci.c b/src/nsdbc/nsdb-update-nci.c
index 22d93f9..5360be5 100644
--- a/src/nsdbc/nsdb-update-nci.c
+++ b/src/nsdbc/nsdb-update-nci.c
@@ -150,10 +150,12 @@  main(int argc, char **argv)
 		case 'y':
 			delete = true;
 			break;
+		case '?':
+			nsdb_update_nci_usage(progname);
+			break;
 		default:
 			fprintf(stderr, "Invalid command line "
 				"argument: %c\n", (char)arg);
-		case '?':
 			nsdb_update_nci_usage(progname);
 		}
 	}