Message ID | 20140511212954.13852.73046.stgit@seurat.1015granger.net |
---|---|
State | Accepted |
Headers | show
Return-Path: <fedfs-utils-devel-bounces@oss.oracle.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C024D140087 for <incoming@patchwork.ozlabs.org>; Mon, 12 May 2014 07:30:05 +1000 (EST) Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s4BLU2Ck028463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 11 May 2014 21:30:03 GMT Received: from oss.oracle.com (oss-external.oracle.com [137.254.96.51]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s4BLU1J5015572 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 11 May 2014 21:30:02 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from <fedfs-utils-devel-bounces@oss.oracle.com>) id 1WjbJp-0004F1-M3; Sun, 11 May 2014 14:30:01 -0700 Received: from acsinet22.oracle.com ([141.146.126.238]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from <chucklever@gmail.com>) id 1WjbJk-0004Eg-Sn for fedfs-utils-devel@oss.oracle.com; Sun, 11 May 2014 14:29:56 -0700 Received: from aserp1020.oracle.com (aserp1020.oracle.com [141.146.126.67]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s4BLTuQk015355 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <fedfs-utils-devel@oss.oracle.com>; Sun, 11 May 2014 21:29:56 GMT Received: from mail-ig0-f170.google.com (mail-ig0-f170.google.com [209.85.213.170]) by aserp1020.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s4BLTtZO027887 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=OK) for <fedfs-utils-devel@oss.oracle.com>; Sun, 11 May 2014 21:29:56 GMT Authentication-Results: aserp1020.oracle.com; dkim=pass reason="2048-bit key" header.d=gmail.com header.i=@gmail.com header.b=S6Y5jyxo Received: by mail-ig0-f170.google.com with SMTP id r10so3978925igi.1 for <fedfs-utils-devel@oss.oracle.com>; Sun, 11 May 2014 14:29:55 -0700 (PDT) X-Received: by 10.50.2.8 with SMTP id 8mr36003140igq.32.1399843795429; Sun, 11 May 2014 14:29:55 -0700 (PDT) Received: from seurat.1015granger.net ([2604:8800:100:81fc:20c:29ff:fe44:ec31]) by mx.google.com with ESMTPSA id a8sm16870629ign.22.2014.05.11.14.29.54 for <fedfs-utils-devel@oss.oracle.com> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 11 May 2014 14:29:54 -0700 (PDT) To: fedfs-utils-devel@oss.oracle.com From: Chuck Lever <chuck.lever@oracle.com> Date: Sun, 11 May 2014 17:29:54 -0400 Message-ID: <20140511212954.13852.73046.stgit@seurat.1015granger.net> In-Reply-To: <20140511212416.13852.92639.stgit@seurat.1015granger.net> References: <20140511212416.13852.92639.stgit@seurat.1015granger.net> User-Agent: StGit/0.16 MIME-Version: 1.0 X-Flow-Control-Info: class=Pass-to-MM reputation=ipRisk-All ip=209.85.213.170 ct-class=R5 ct-vol1=-93 ct-vol2=8 ct-vol3=7 ct-risk=48 ct-spam1=75 ct-spam2=7 ct-bulk=6 rcpts=1 size=600 X-Sendmail-CM-Score: 0.00% X-Sendmail-CM-Analysis: v=2.1 cv=I/xcGrQg c=1 sm=1 tr=0 a=4NlNMipMRxsRUqezHI480A==:117 a=dzsqy3y4QnMA:10 a=w80PY1KfphQA:10 a=dPGociXpb70A:10 a=IkcTkHD0fZMA:10 a=xqWC_Br6kY4A:10 a=yPCof4ZbAAAA:8 a=Lb1rMZzfAAAA:8 a=1XWaLZrsAAAA:8 a=wUW7V82lqgLPBysW514A:9 a=QEXdDO 2ut3YA:10 a=7DSvI1NPTFQA:10 X-Sendmail-CT-RefID: str=0001.0A020203.536FEBD4.0043, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-Sendmail-CT-Classification: not spam Subject: [fedfs-utils] [PATCH 13/17] libadmin: Fix resource leak in admin_create() X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers <fedfs-utils-devel@oss.oracle.com> List-Id: fedfs-utils Developers <fedfs-utils-devel.oss.oracle.com> List-Unsubscribe: <https://oss.oracle.com/mailman/listinfo/fedfs-utils-devel>, <mailto:fedfs-utils-devel-request@oss.oracle.com?subject=unsubscribe> List-Archive: <http://oss.oracle.com/pipermail/fedfs-utils-devel> List-Post: <mailto:fedfs-utils-devel@oss.oracle.com> List-Help: <mailto:fedfs-utils-devel-request@oss.oracle.com?subject=help> List-Subscribe: <https://oss.oracle.com/mailman/listinfo/fedfs-utils-devel>, <mailto:fedfs-utils-devel-request@oss.oracle.com?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: acsinet22.oracle.com [141.146.126.238] |
diff --git a/src/libadmin/admin.c b/src/libadmin/admin.c index ba3ead3..4770c98 100644 --- a/src/libadmin/admin.c +++ b/src/libadmin/admin.c @@ -315,8 +315,10 @@ admin_create(const char *hostname, const char *nettype, const char *security, return err; err = admin_open(new); - if (err != 0) + if (err != 0) { + admin_release(new); return err; + } *result = new; return 0;
Fixes: 1bbee83fc7aaa74635cf37ae41e6d6ade753a62b Signed-off-by: Chuck Lever <chuck.lever@oracle.com> --- src/libadmin/admin.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)