From patchwork Sun May 11 19:59:19 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Polacek X-Patchwork-Id: 347815 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id CD968140084 for ; Mon, 12 May 2014 05:59:38 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; q=dns; s=default; b=VayRLnFQwmq96ZncE rVZ0a8pKwdIvAuXCaMFDv78Sk/cz4FuHsrE8XfORm7bMEwYJbrIWmoA886Sefn7T lzM/bGXNe4Op6C41FEWeNF3jS7MxczDJZ3jAL8ht4HB/QoKPyrGUnKDoEMD3Gwpd uhjCJHMozLMYtc+aGsr3OmDulM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=default; bh=DJEledQx+kq+dpM0PPvb4fO Q0mM=; b=ftGBd8AqkViXSxarTL7Ohy685Y/H5oGZa9ewK+3DCQsdPubi28qzkTo BpJXUBwhctmEM8VDeEX/tlNAf8T+3IjXPOvoYfyQfRrmNqurmQS76AQyYRagASuX oeFqeqo+WYRT9Y+oEspEgreKjT58e50iv5hcMwnobGWjvQP1R6J0= Received: (qmail 22217 invoked by alias); 11 May 2014 19:59:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 22202 invoked by uid 89); 11 May 2014 19:59:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 11 May 2014 19:59:29 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4BJxOuM001773 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 11 May 2014 15:59:24 -0400 Received: from redhat.com (ovpn-116-29.ams2.redhat.com [10.36.116.29]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s4BJxKPd022035 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 11 May 2014 15:59:22 -0400 Date: Sun, 11 May 2014 21:59:19 +0200 From: Marek Polacek To: Rainer Orth Cc: Dominique Dhumieres , gcc-patches@gcc.gnu.org, iains@gcc.gnu.org, joseph@codesourcery.com Subject: Re: [C PATCH] Make attributes accept enum values (PR c/50459) Message-ID: <20140511195919.GE23554@redhat.com> References: <20140510141047.3D98C103@mailhost.lps.ens.fr> <20140511180141.GD23554@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) On Sun, May 11, 2014 at 09:18:47PM +0200, Rainer Orth wrote: > No, that's wrong: avoid hardcoding target lists if at all possible. > Besides, it's wrong since it doesn't cover the Solaris (and other > non-gld linker) case. Use the init_priority effective-target keyword > instead. Also, please check if you can use dg-xfail-if instead: if > anything changes, the test turns into an XPASS instead of the change > going unnoticed with dg-skip-if. I don't see tests using dg-skip-if and init_priority, so this patch does what we do for other tests using cdtor priorities. 2014-05-11 Marek Polacek * c-c++-common/pr50459.c: Require init_priority target. Marek diff --git gcc/testsuite/c-c++-common/pr50459.c gcc/testsuite/c-c++-common/pr50459.c index f837b63..ee586b4 100644 --- gcc/testsuite/c-c++-common/pr50459.c +++ gcc/testsuite/c-c++-common/pr50459.c @@ -1,5 +1,5 @@ /* PR c/50459 */ -/* { dg-do compile } */ +/* { dg-do compile { target init_priority } } */ /* { dg-options "-Wall -Wextra" } */ enum { A = 128, B = 1 };