| Message ID | bce8edd889a7bc696824.1399822727@argentina |
|---|---|
| State | Superseded |
| Headers | show |
Thomas, All, On 2014-05-11 17:38 +0200, Thomas De Schampheleire spake thusly: > As mentioned in the e-mail accompanying the introduction of the pkg-virtual > infrastructure [1], the definition of FOO_VERSION is 'strange'. > > After the cleanup of single/double dollar signs in inner-generic-package, > the special construction in pkg-virtual is no longer needed and can be > simplified. > > Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Provided the preceding patches are applied (as-is or after being reworked, of course): Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > [1] http://lists.busybox.net/pipermail/buildroot/2014-April/093670.html > > --- > package/pkg-virtual.mk | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/package/pkg-virtual.mk b/package/pkg-virtual.mk > --- a/package/pkg-virtual.mk > +++ b/package/pkg-virtual.mk > @@ -45,8 +45,7 @@ endif > $(2)_SOURCE = > > # Fake a version string, so it looks nicer in the build log > -$(3)_VERSION = virtual > -HOST_$(3)_VERSION = virtual > +$(2)_VERSION = virtual > > # This must be repeated from inner-generic-package, otherwise we get an empty > # _DEPENDENCIES
diff --git a/package/pkg-virtual.mk b/package/pkg-virtual.mk --- a/package/pkg-virtual.mk +++ b/package/pkg-virtual.mk @@ -45,8 +45,7 @@ endif $(2)_SOURCE = # Fake a version string, so it looks nicer in the build log -$(3)_VERSION = virtual -HOST_$(3)_VERSION = virtual +$(2)_VERSION = virtual # This must be repeated from inner-generic-package, otherwise we get an empty # _DEPENDENCIES
As mentioned in the e-mail accompanying the introduction of the pkg-virtual infrastructure [1], the definition of FOO_VERSION is 'strange'. After the cleanup of single/double dollar signs in inner-generic-package, the special construction in pkg-virtual is no longer needed and can be simplified. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> [1] http://lists.busybox.net/pipermail/buildroot/2014-April/093670.html --- package/pkg-virtual.mk | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)