Patchwork [11/14] monitor: Convert do_balloon() to QObject

login
register
mail settings
Submitter Luiz Capitulino
Date Oct. 1, 2009, 3:50 p.m.
Message ID <1254412245-10452-12-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/34746/
State Superseded
Headers show

Comments

Luiz Capitulino - Oct. 1, 2009, 3:50 p.m.
It is important to observe that it never fails, as big refactoring
of the virtio code would be needed to get the proper error code.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c       |    7 +++++--
 qemu-monitor.hx |    4 ++--
 2 files changed, 7 insertions(+), 4 deletions(-)

Patch

diff --git a/monitor.c b/monitor.c
index 87fd91c..852e558 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1636,8 +1636,11 @@  static void do_info_status(Monitor *mon)
        monitor_printf(mon, "VM status: paused\n");
 }
 
-
-static void do_balloon(Monitor *mon, const QDict *qdict)
+/**
+ * do_balloon(): Request VM to change its memory allocation
+ */
+static void do_balloon(Monitor *mon, const QDict *qdict, QObject **ret_data,
+                       MonitorError *error)
 {
     int value = qdict_get_int(qdict, "value");
     ram_addr_t target = value;
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index e848b1d..7cde9d9 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -936,8 +936,8 @@  ETEXI
         .name       = "balloon",
         .args_type  = "value:i",
         .handler    = do_balloon,
-        .user_print = NULL,
-        .user_error = NULL,
+        .user_print = monitor_user_noop,
+        .user_error = monitor_error_noop,
         .params     = "target",
         .help       = "request VM to change it's memory allocation (in MB)"
     },