diff mbox

[RFC,2/2] drm/panel: update simple-panel DT bindings doc with panel desc properties

Message ID 1399645002-18000-3-git-send-email-boris.brezillon@free-electrons.com
State Superseded, archived
Headers show

Commit Message

Boris Brezillon May 9, 2014, 2:16 p.m. UTC
Document simple-panel description properties and subnodes.

The display-timings definition is the one described in
Documentation/devicetree/bindings/video/display-timing.txt.

Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
---
 .../devicetree/bindings/panel/simple-panel.txt     | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)

Comments

Thierry Reding May 13, 2014, 7:53 a.m. UTC | #1
On Fri, May 09, 2014 at 04:16:42PM +0200, Boris BREZILLON wrote:
> Document simple-panel description properties and subnodes.
> 
> The display-timings definition is the one described in
> Documentation/devicetree/bindings/video/display-timing.txt.
> 
> Signed-off-by: Boris BREZILLON <boris.brezillon@free-electrons.com>
> ---
>  .../devicetree/bindings/panel/simple-panel.txt     | 34 ++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/panel/simple-panel.txt b/Documentation/devicetree/bindings/panel/simple-panel.txt
> index 1341bbf..3440f78 100644
> --- a/Documentation/devicetree/bindings/panel/simple-panel.txt
> +++ b/Documentation/devicetree/bindings/panel/simple-panel.txt
> @@ -7,6 +7,13 @@ Optional properties:
>  - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
>  - enable-gpios: GPIO pin to enable or disable the panel
>  - backlight: phandle of the backlight device attached to the panel
> +- height: the screen height in pixels
> +- width: the screen width in pixels

width and height are not in pixels. They are in millimeters.

Thierry
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/panel/simple-panel.txt b/Documentation/devicetree/bindings/panel/simple-panel.txt
index 1341bbf..3440f78 100644
--- a/Documentation/devicetree/bindings/panel/simple-panel.txt
+++ b/Documentation/devicetree/bindings/panel/simple-panel.txt
@@ -7,6 +7,13 @@  Optional properties:
 - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing
 - enable-gpios: GPIO pin to enable or disable the panel
 - backlight: phandle of the backlight device attached to the panel
+- height: the screen height in pixels
+- width: the screen width in pixels
+
+Optional children nodes:
+- display-timings: encode the panel timings.
+  see Documentation/devicetree/bindings/video/display-timing.txt for a full
+  description.
 
 Example:
 
@@ -19,3 +26,30 @@  Example:
 
 		backlight = <&backlight>;
 	};
+
+or
+        panel: panel {
+                compatible = "simple-panel";
+		enable-gpios = <&gpio 90 0>;
+
+		backlight = <&backlight>;
+
+		width = 1920;
+		height = 1080;
+		display-timings {
+	                native-mode = <&timing0>;
+			timing0: 1080p24 {
+				/* 1920x1080p24 */
+				clock-frequency = <52000000>;
+				hactive = <1920>;
+				vactive = <1080>;
+				hfront-porch = <25>;
+				hback-porch = <25>;
+				hsync-len = <25>;
+				vback-porch = <2>;
+				vfront-porch = <2>;
+				vsync-len = <2>;
+				hsync-active = <1>;
+			};
+		};
+	};