Patchwork [net-next] sch_hhf: fix comparison of qlen and limit

login
register
mail settings
Submitter Yang Yingliang
Date May 9, 2014, 8:49 a.m.
Message ID <1399625345-6588-1-git-send-email-yangyingliang@huawei.com>
Download mbox | patch
Permalink /patch/347344/
State Accepted
Delegated to: David Miller
Headers show

Comments

Yang Yingliang - May 9, 2014, 8:49 a.m.
When I use the following command, eth0 cannot send any packets.
 #tc qdisc add dev eth0 root handle 1: hhf limit 1

Because qlen need be smaller than limit, all packets were dropped.
Fix this by qlen *<=* limit.

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 net/sched/sch_hhf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - May 12, 2014, 6:55 p.m.
From: Yang Yingliang <yangyingliang@huawei.com>
Date: Fri, 9 May 2014 16:49:05 +0800

> When I use the following command, eth0 cannot send any packets.
>  #tc qdisc add dev eth0 root handle 1: hhf limit 1
> 
> Because qlen need be smaller than limit, all packets were dropped.
> Fix this by qlen *<=* limit.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/sched/sch_hhf.c b/net/sched/sch_hhf.c
index a9051d0fff52..9544c5caadb9 100644
--- a/net/sched/sch_hhf.c
+++ b/net/sched/sch_hhf.c
@@ -414,7 +414,7 @@  static int hhf_enqueue(struct sk_buff *skb, struct Qdisc *sch)
 		}
 		bucket->deficit = weight * q->quantum;
 	}
-	if (++sch->q.qlen < sch->limit)
+	if (++sch->q.qlen <= sch->limit)
 		return NET_XMIT_SUCCESS;
 
 	q->drop_overlimit++;