Patchwork mtd: nand: davinci: fix to use mask_ale from pdata

login
register
mail settings
Submitter Hemant Pedanekar
Date Oct. 1, 2009, 2:25 p.m.
Message ID <1254407106-19390-1-git-send-email-hemantp@ti.com>
Download mbox | patch
Permalink /patch/34727/
State New
Headers show

Comments

Hemant Pedanekar - Oct. 1, 2009, 2:25 p.m.
Correct typo to use mask_ale from platform data when set to non-zero.

Signed-off-by: Hemant Pedanekar <hemantp@ti.com>
---
 drivers/mtd/nand/davinci_nand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Kevin Hilman - Oct. 8, 2009, 3:16 p.m.
Hemant Pedanekar <hemantp@ti.com> writes:

> Correct typo to use mask_ale from platform data when set to non-zero.
>
> Signed-off-by: Hemant Pedanekar <hemantp@ti.com>

Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>

Could this fix be queued for the .32-rc series please?

Thanks,

Kevin

> ---
>  drivers/mtd/nand/davinci_nand.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index 0fad648..20b04a2 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
> @@ -571,7 +571,7 @@ static int __init nand_davinci_probe(struct platform_device *pdev)
>  	info->mask_chipsel	= pdata->mask_chipsel;
>  
>  	/* use nandboot-capable ALE/CLE masks by default */
> -	info->mask_ale		= pdata->mask_cle ? : MASK_ALE;
> +	info->mask_ale		= pdata->mask_ale ? : MASK_ALE;
>  	info->mask_cle		= pdata->mask_cle ? : MASK_CLE;
>  
>  	/* Set address of hardware control function */
> -- 
> 1.6.2.4
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
nsnehaprabha@ti.com - Oct. 8, 2009, 3:37 p.m.
Andrew,

Could you please apply this patch to the -mm tree and thus queue it up for 2.6.32-rc series?

Thanks
Sneha

> -----Original Message-----
> From: davinci-linux-open-source-bounces@linux.davincidsp.com
> [mailto:davinci-linux-open-source-bounces@linux.davincidsp.com] On Behalf
> Of Kevin Hilman
> Sent: Thursday, October 08, 2009 11:16 AM
> To: Pedanekar, Hemant
> Cc: Artem.Bityutskiy@nokia.com; davinci-linux-open-
> source@linux.davincidsp.com; dbrownell@users.sourceforge.net; linux-
> mtd@lists.infradead.org; akpm@linux-foundation.org; dwmw2@infradead.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] mtd: nand: davinci: fix to use mask_ale from pdata
> 
> Hemant Pedanekar <hemantp@ti.com> writes:
> 
> > Correct typo to use mask_ale from platform data when set to non-zero.
> >
> > Signed-off-by: Hemant Pedanekar <hemantp@ti.com>
> 
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
> 
> Could this fix be queued for the .32-rc series please?
> 
> Thanks,
> 
> Kevin
> 
> > ---
> >  drivers/mtd/nand/davinci_nand.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/davinci_nand.c
> b/drivers/mtd/nand/davinci_nand.c
> > index 0fad648..20b04a2 100644
> > --- a/drivers/mtd/nand/davinci_nand.c
> > +++ b/drivers/mtd/nand/davinci_nand.c
> > @@ -571,7 +571,7 @@ static int __init nand_davinci_probe(struct
> platform_device *pdev)
> >  	info->mask_chipsel	= pdata->mask_chipsel;
> >
> >  	/* use nandboot-capable ALE/CLE masks by default */
> > -	info->mask_ale		= pdata->mask_cle ? : MASK_ALE;
> > +	info->mask_ale		= pdata->mask_ale ? : MASK_ALE;
> >  	info->mask_cle		= pdata->mask_cle ? : MASK_CLE;
> >
> >  	/* Set address of hardware control function */
> > --
> > 1.6.2.4
> >
> > _______________________________________________
> > Davinci-linux-open-source mailing list
> > Davinci-linux-open-source@linux.davincidsp.com
> > http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
> 
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Artem Bityutskiy - Oct. 9, 2009, 4:17 a.m.
On 10/08/2009 06:37 PM, ext Narnakaje, Snehaprabha wrote:
> Andrew,
>
> Could you please apply this patch to the -mm tree and thus queue it up for 2.6.32-rc series?

FYI, this patch is already in the mtd-2.6.git tree. So you should bug
dwmw2 to push it to rc3

Patch

diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index 0fad648..20b04a2 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -571,7 +571,7 @@  static int __init nand_davinci_probe(struct platform_device *pdev)
 	info->mask_chipsel	= pdata->mask_chipsel;
 
 	/* use nandboot-capable ALE/CLE masks by default */
-	info->mask_ale		= pdata->mask_cle ? : MASK_ALE;
+	info->mask_ale		= pdata->mask_ale ? : MASK_ALE;
 	info->mask_cle		= pdata->mask_cle ? : MASK_CLE;
 
 	/* Set address of hardware control function */