Patchwork [Karmic] SRU: acerhdf: Limit modalias matching to supported boards

login
register
mail settings
Submitter Stefan Bader
Date Oct. 1, 2009, 2:33 p.m.
Message ID <4AC4BDC8.6060900@canonical.com>
Download mbox | patch
Permalink /patch/34726/
State Accepted
Headers show

Comments

Stefan Bader - Oct. 1, 2009, 2:33 p.m.
SRU Justification:

Impact: When the acerhk module is loaded on non Aspire One systems it will 
issue a warning about finding a bad/unknown BIOS version. It will not load and 
there is no bad effect, beside users getting scared.

Fix: Limit the modalias to only boardnames starting with AOA

Testcase: Booting on Aspire One still loads the module, other laptops don't see 
the warning anymore.
Tim Gardner - Oct. 1, 2009, 3:50 p.m.
Stefan Bader wrote:
> SRU Justification:
> 
> Impact: When the acerhk module is loaded on non Aspire One systems it
> will issue a warning about finding a bad/unknown BIOS version. It will
> not load and there is no bad effect, beside users getting scared.
> 
> Fix: Limit the modalias to only boardnames starting with AOA
> 
> Testcase: Booting on Aspire One still loads the module, other laptops
> don't see the warning anymore.
> 

applied

Patch

From 389f61f7e66ce615dc6418cb856e167edaa74b42 Mon Sep 17 00:00:00 2001
From: Stefan Bader <stefan.bader@canonical.com>
Date: Mon, 28 Sep 2009 17:11:29 +0000
Subject: [PATCH] UBUNTU: SAUCE: acerhdf: Limit modalias matching to supported boards

BugLink: https://bugs.launchpad.net/ubuntu/+bug/435958

Upstream status: acked, but not accepted, yet

The module alias currently matches any Acer computer but when loaded the
BIOS checks will only succeed on Aspire One models. This causes a invalid
BIOS warning for all other models (seen on Aspire 4810T).
This is not fatal but worries users that see this message. Limiting the
moule alias to models starting with AOA. Probably the same change should be
made for the two other entries.

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Acked-by: Borislav Petkov <petkovbb@gmail.com>
---
 drivers/platform/x86/acerhdf.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
index aa298d6..763f233 100644
--- a/drivers/platform/x86/acerhdf.c
+++ b/drivers/platform/x86/acerhdf.c
@@ -629,7 +629,7 @@  static void __exit acerhdf_exit(void)
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Peter Feuerer");
 MODULE_DESCRIPTION("Aspire One temperature and fan driver");
-MODULE_ALIAS("dmi:*:*Acer*:*:");
+MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
 MODULE_ALIAS("dmi:*:*Gateway*:*:");
 MODULE_ALIAS("dmi:*:*Packard Bell*:*:");
 
-- 
1.5.4.5