Patchwork ptp: fix kconfig dependency warnings

login
register
mail settings
Submitter Randy Dunlap
Date May 8, 2014, 9:54 p.m.
Message ID <536BFD22.3020505@infradead.org>
Download mbox | patch
Permalink /patch/347259/
State Accepted
Delegated to: David Miller
Headers show

Comments

Randy Dunlap - May 8, 2014, 9:54 p.m.
From: Randy Dunlap <rdunlap@infradead.org>

Fix kconfig warnings:

PTP_1588_CLOCK selects NET_PTP_CLASSIFY, which depends on NET,
so PTP_1588_CLOCK should also depend on NET.

PTP_1588_CLOCK_PCH selects PTP_1588_CLOCK so the former should
depend on NET.

warning: (IXP4XX_ETH && PTP_1588_CLOCK) selects NET_PTP_CLASSIFY which has unmet direct dependencies (NET)

warning: (SFC && TILE_NET && BFIN_MAC_USE_HWSTAMP && TIGON3 && FEC && E1000E && IGB && IXGBE && I40E && MLX4_EN && SXGBE_ETH && STMMAC_ETH && TI_CPTS && PTP_1588_CLOCK_GIANFAR && PTP_1588_CLOCK_IXP46X && DP83640_PHY && PTP_1588_CLOCK_PCH) selects PTP_1588_CLOCK which has unmet direct dependencies (NET)
[This warning is caused by the new 'depends on NET' in PTP_1588_CLOCK.]

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
 drivers/ptp/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Found in linux-next but applies to mainline.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Richard Cochran - May 9, 2014, 4:29 a.m.
On Thu, May 08, 2014 at 02:54:42PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix kconfig warnings:

Acked-by: Richard Cochran <richardcochran@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - May 12, 2014, 4:27 a.m.
From: Randy Dunlap <rdunlap@infradead.org>
Date: Thu, 08 May 2014 14:54:42 -0700

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix kconfig warnings:
> 
> PTP_1588_CLOCK selects NET_PTP_CLASSIFY, which depends on NET,
> so PTP_1588_CLOCK should also depend on NET.
> 
> PTP_1588_CLOCK_PCH selects PTP_1588_CLOCK so the former should
> depend on NET.
> 
> warning: (IXP4XX_ETH && PTP_1588_CLOCK) selects NET_PTP_CLASSIFY which has unmet direct dependencies (NET)
> 
> warning: (SFC && TILE_NET && BFIN_MAC_USE_HWSTAMP && TIGON3 && FEC && E1000E && IGB && IXGBE && I40E && MLX4_EN && SXGBE_ETH && STMMAC_ETH && TI_CPTS && PTP_1588_CLOCK_GIANFAR && PTP_1588_CLOCK_IXP46X && DP83640_PHY && PTP_1588_CLOCK_PCH) selects PTP_1588_CLOCK which has unmet direct dependencies (NET)
> [This warning is caused by the new 'depends on NET' in PTP_1588_CLOCK.]
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Applied, thanks Randy.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- linux-next-20140508.orig/drivers/ptp/Kconfig
+++ linux-next-20140508/drivers/ptp/Kconfig
@@ -6,6 +6,7 @@  menu "PTP clock support"
 
 config PTP_1588_CLOCK
 	tristate "PTP clock support"
+	depends on NET
 	select PPS
 	select NET_PTP_CLASSIFY
 	help
@@ -74,7 +75,7 @@  config DP83640_PHY
 config PTP_1588_CLOCK_PCH
 	tristate "Intel PCH EG20T as PTP clock"
 	depends on X86 || COMPILE_TEST
-	depends on HAS_IOMEM
+	depends on HAS_IOMEM && NET
 	select PTP_1588_CLOCK
 	help
 	  This driver adds support for using the PCH EG20T as a PTP