| Message ID | 20140508174117.GA28072@phenom.hsd1.va.comcast.net |
|---|---|
| State | Accepted |
| Headers | show |
Thomas Tsou wrote: > 3GPP TS 05.03 "Channel coding" specifies the puncturing matrix (1,0,1) > for class 1 information bits and tail bits valued u(0) to u(103) for a > maximum puncturing index of 311. The puncturing index 313 exceeds the > maximum index and causes osmo_conv_get_output_length() to output the > improper length of 210 instead of 211. > > Signed-off-by: Thomas Tsou <tom@tsou.cc> > --- > src/osmo-bts-trx/gsm0503_conv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/osmo-bts-trx/gsm0503_conv.c b/src/osmo-bts-trx/gsm0503_conv.c > index 2a814ca..dc50e6c 100644 > --- a/src/osmo-bts-trx/gsm0503_conv.c > +++ b/src/osmo-bts-trx/gsm0503_conv.c > @@ -139,7 +139,7 @@ static const int conv_tch_hr_puncture[] = { > 253, 256, 259, 262, 265, 268, 271, 274, 277, 280, 283, > > /* Tail bits */ > - 295, 298, 301, 304, 307, 310, 313, > + 295, 298, 301, 304, 307, 310, > > /* End */ > -1, hi thomas, thanx for the patch. i blindly applied it, since it look reasonable but i have no time to test/review it. it is in the branch jolly/trx_rebased. please let me know if it works or not. did you test it with a half rate v1 call? best regards, andreas
On Thu, May 8, 2014 at 2:35 PM, Andreas Eversberg <andreas@eversberg.eu> wrote: > thanx for the patch. i blindly applied it, since it look reasonable but > i have no time to test/review it. it is in the branch jolly/trx_rebased. > please let me know if it works or not. did you test it with a half rate > v1 call? I tested it with the libosmocore 'make check' code. I did not place any calls. The length at the encoder output was correct. Only the length when calling osmo_conv_get_output_length() on the code was in error. -TT
diff --git a/src/osmo-bts-trx/gsm0503_conv.c b/src/osmo-bts-trx/gsm0503_conv.c index 2a814ca..dc50e6c 100644 --- a/src/osmo-bts-trx/gsm0503_conv.c +++ b/src/osmo-bts-trx/gsm0503_conv.c @@ -139,7 +139,7 @@ static const int conv_tch_hr_puncture[] = { 253, 256, 259, 262, 265, 268, 271, 274, 277, 280, 283, /* Tail bits */ - 295, 298, 301, 304, 307, 310, 313, + 295, 298, 301, 304, 307, 310, /* End */ -1,
3GPP TS 05.03 "Channel coding" specifies the puncturing matrix (1,0,1) for class 1 information bits and tail bits valued u(0) to u(103) for a maximum puncturing index of 311. The puncturing index 313 exceeds the maximum index and causes osmo_conv_get_output_length() to output the improper length of 210 instead of 211. Signed-off-by: Thomas Tsou <tom@tsou.cc> --- src/osmo-bts-trx/gsm0503_conv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)