| Message ID | 1399547163-16824-1-git-send-email-mjt@msgid.tls.msk.ru |
|---|---|
| State | New |
| Headers | show |
On Thu, 05/08 15:06, Michael Tokarev wrote: > We have $(INSTALL_LIB) which is the same as $(INSTALL_PROG) but > uses correct permissions. Loadable objects (modules) are like > shared libraries, not like programs. > > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> > Cc: Fam Zheng <famz@redhat.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> Reviewed-by: Fam Zheng <famz@redhat.com> > --- > Again, this is done on top of $(STRIP) patch, but can be done by > its own. > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 23ca444..12ea464 100644 > --- a/Makefile > +++ b/Makefile > @@ -381,7 +381,7 @@ ifneq ($(CONFIG_MODULES),) > $(INSTALL_DIR) "$(DESTDIR)$(qemu_moddir)" > for s in $(modules-m:.mo=$(DSOSUF)); do \ > t="$(DESTDIR)$(qemu_moddir)/$$(echo $$s | tr / -)"; \ > - $(INSTALL_PROG) $$s "$$t"; \ > + $(INSTALL_LIB) $$s "$$t"; \ > test -z "$(STRIP)" || $(STRIP) "$$t"; \ > done > endif > -- > 1.7.10.4 > >
diff --git a/Makefile b/Makefile index 23ca444..12ea464 100644 --- a/Makefile +++ b/Makefile @@ -381,7 +381,7 @@ ifneq ($(CONFIG_MODULES),) $(INSTALL_DIR) "$(DESTDIR)$(qemu_moddir)" for s in $(modules-m:.mo=$(DSOSUF)); do \ t="$(DESTDIR)$(qemu_moddir)/$$(echo $$s | tr / -)"; \ - $(INSTALL_PROG) $$s "$$t"; \ + $(INSTALL_LIB) $$s "$$t"; \ test -z "$(STRIP)" || $(STRIP) "$$t"; \ done endif
We have $(INSTALL_LIB) which is the same as $(INSTALL_PROG) but uses correct permissions. Loadable objects (modules) are like shared libraries, not like programs. Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> Cc: Fam Zheng <famz@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> --- Again, this is done on top of $(STRIP) patch, but can be done by its own. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)