| Message ID | 018e01cf69ac$a4479600$ecd6c200$%han@samsung.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Jingoo, Thank you for the patch. On Wednesday 07 May 2014 13:27:22 Jingoo Han wrote: > The site-specific OOM messages are unnecessary, because they > duplicate the MM subsystem generic OOM message. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/i2c/busses/i2c-sh_mobile.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-sh_mobile.c > b/drivers/i2c/busses/i2c-sh_mobile.c index 1d79585..fbc13e9 100644 > --- a/drivers/i2c/busses/i2c-sh_mobile.c > +++ b/drivers/i2c/busses/i2c-sh_mobile.c > @@ -665,10 +665,8 @@ static int sh_mobile_i2c_probe(struct platform_device > *dev) int ret; > > pd = kzalloc(sizeof(struct sh_mobile_i2c_data), GFP_KERNEL); > - if (pd == NULL) { > - dev_err(&dev->dev, "cannot allocate private data\n"); > + if (pd == NULL) > return -ENOMEM; > - } > > pd->clk = clk_get(&dev->dev, NULL); > if (IS_ERR(pd->clk)) {
diff --git a/drivers/i2c/busses/i2c-sh_mobile.c b/drivers/i2c/busses/i2c-sh_mobile.c index 1d79585..fbc13e9 100644 --- a/drivers/i2c/busses/i2c-sh_mobile.c +++ b/drivers/i2c/busses/i2c-sh_mobile.c @@ -665,10 +665,8 @@ static int sh_mobile_i2c_probe(struct platform_device *dev) int ret; pd = kzalloc(sizeof(struct sh_mobile_i2c_data), GFP_KERNEL); - if (pd == NULL) { - dev_err(&dev->dev, "cannot allocate private data\n"); + if (pd == NULL) return -ENOMEM; - } pd->clk = clk_get(&dev->dev, NULL); if (IS_ERR(pd->clk)) {
The site-specific OOM messages are unnecessary, because they duplicate the MM subsystem generic OOM message. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/i2c/busses/i2c-sh_mobile.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)