diff mbox

[02/16] i2c: diolan-u2c: remove unnecessary OOM messages

Message ID 018601cf69ab$26b2f460$7418dd20$%han@samsung.com
State Superseded
Headers show

Commit Message

Jingoo Han May 7, 2014, 4:16 a.m. UTC
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/i2c/busses/i2c-diolan-u2c.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Guenter Roeck May 7, 2014, 4:49 a.m. UTC | #1
On 05/06/2014 09:16 PM, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>

Acked-by: Guenter Roeck <linux@roeck-us.net>

The driver could also use a conversion to devm_kzalloc() ...

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/i2c/busses/i2c-diolan-u2c.c b/drivers/i2c/busses/i2c-diolan-u2c.c
index 721f7eb..b19a310 100644
--- a/drivers/i2c/busses/i2c-diolan-u2c.c
+++ b/drivers/i2c/busses/i2c-diolan-u2c.c
@@ -455,7 +455,6 @@  static int diolan_u2c_probe(struct usb_interface *interface,
 	/* allocate memory for our device state and initialize it */
 	dev = kzalloc(sizeof(*dev), GFP_KERNEL);
 	if (dev == NULL) {
-		dev_err(&interface->dev, "no memory for device state\n");
 		ret = -ENOMEM;
 		goto error;
 	}