Patchwork UBUNTU: SAUCE: Added quirk to enable sound on Toshiba NB200

login
register
mail settings
Submitter Manoj Iyer
Date Sept. 30, 2009, 9:58 p.m.
Message ID <alpine.DEB.2.00.0909301654220.6604@little>
Download mbox | patch
Permalink /patch/34630/
State Accepted
Headers show

Comments

Manoj Iyer - Sept. 30, 2009, 9:58 p.m.
This patch enables sound on Toshiba NB200/205 netbooks. I submitted the 
patch upstream, and maintainer wants me to test 2.6.32-rc1, as the recent 
fixes might have fixed this without the quirk. Submitting to the list in 
case we need it sooner.

From a09d48287041b355400372029415ac163179b829 Mon Sep 17 00:00:00 2001
From: Manoj Iyer <manjo@hungry.(none)>
Date: Wed, 30 Sep 2009 16:44:06 -0500
Subject: [PATCH] UBUNTU: SAUCE: Added quirk to enable sound on Toshiba NB200

Submitted patch upstream.

BugLink: http://bugs.launchpad.net/bugs/438318

Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
---
  sound/pci/hda/patch_realtek.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
Manoj Iyer - Oct. 1, 2009, 6:03 a.m.
I think I messed up the push to zinc, here is a cleaner version.

The following changes since commit 
8ef5591fa4392b4228b0be97013a8218f267ef90:
   Tim Gardner (1):
         UBUNTU: [Upstream] i915: Fix i2c init message

are available in the git repository at:

   git://kernel.ubuntu.com/manjo/ubuntu-karmic-sru.git lp438318

Manoj Iyer (1):
       UBUNTU: SAUCE: Added quirk to enable sound on Toshiba NB200

  sound/pci/hda/patch_realtek.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)


On Wed, 30 Sep 2009, Manoj Iyer wrote:

>
> This patch enables sound on Toshiba NB200/205 netbooks. I submitted the
> patch upstream, and maintainer wants me to test 2.6.32-rc1, as the recent
> fixes might have fixed this without the quirk. Submitting to the list in
> case we need it sooner.
>
> From a09d48287041b355400372029415ac163179b829 Mon Sep 17 00:00:00 2001
> From: Manoj Iyer <manjo@hungry.(none)>
> Date: Wed, 30 Sep 2009 16:44:06 -0500
> Subject: [PATCH] UBUNTU: SAUCE: Added quirk to enable sound on Toshiba NB200
>
> Submitted patch upstream.
>
> BugLink: http://bugs.launchpad.net/bugs/438318
>
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> ---
>  sound/pci/hda/patch_realtek.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 30eeb30..713bf69 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -16876,6 +16876,7 @@ static struct snd_pci_quirk alc662_cfg_tbl[] = {
>  	SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_ECS),
>  	SND_PCI_QUIRK(0x105b, 0x0d47, "Foxconn 45CMX/45GMX/45CMX-K",
>  		      ALC662_3ST_6ch_DIG),
> +	SND_PCI_QUIRK(0x1179, 0xff6e, "Toshiba NB200", ALC663_ASUS_MODE4),
>  	SND_PCI_QUIRK(0x144d, 0xca00, "Samsung NC10", ALC272_SAMSUNG_NC10),
>  	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte 945GCM-S2L",
>  		      ALC662_3ST_6ch_DIG),
> -- 
> 1.6.3.3
>
>
> The following changes since commit
> 756d7655a09ade66d08fffe73854fce81b7f82a8:
>   Tim Gardner (1):
>         UBUNTU: [Config] Fix a couple more instances of SRCPKGNAME-headers
>
> are available in the git repository at:
>
>   git://kernel.ubuntu.com/manjo/ubuntu-karmic.git lp438318
>
> Manoj Iyer (2):
>       UBUNTU: LP#438323 Added omnibook module to support Toshiba (HP)
> netbooks
>       UBUNTU: SAUCE: Added quirk to enable sound on Toshiba NB200
>
>
> --- manjo
>
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Tim Gardner - Oct. 1, 2009, 1:26 p.m.
Manoj Iyer wrote:
> This patch enables sound on Toshiba NB200/205 netbooks. I submitted the 
> patch upstream, and maintainer wants me to test 2.6.32-rc1, as the recent 
> fixes might have fixed this without the quirk. Submitting to the list in 
> case we need it sooner.
> 
> From a09d48287041b355400372029415ac163179b829 Mon Sep 17 00:00:00 2001
> From: Manoj Iyer <manjo@hungry.(none)>
> Date: Wed, 30 Sep 2009 16:44:06 -0500
> Subject: [PATCH] UBUNTU: SAUCE: Added quirk to enable sound on Toshiba NB200
> 
> Submitted patch upstream.
> 
> BugLink: http://bugs.launchpad.net/bugs/438318
> 
> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
> ---
>   sound/pci/hda/patch_realtek.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 30eeb30..713bf69 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -16876,6 +16876,7 @@ static struct snd_pci_quirk alc662_cfg_tbl[] = {
>   	SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_ECS),
>   	SND_PCI_QUIRK(0x105b, 0x0d47, "Foxconn 45CMX/45GMX/45CMX-K",
>   		      ALC662_3ST_6ch_DIG),
> +	SND_PCI_QUIRK(0x1179, 0xff6e, "Toshiba NB200", ALC663_ASUS_MODE4),
>   	SND_PCI_QUIRK(0x144d, 0xca00, "Samsung NC10", ALC272_SAMSUNG_NC10),
>   	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte 945GCM-S2L",
>   		      ALC662_3ST_6ch_DIG),

Now that Andy has mainline 2.6.32-rc1 building, it shouldn't take too
long to test if this is already fixed upstream. In which case its a
simple cherry-pick (hopefully) v.s. another SAUCE patch that we have to
worry about getting into Lucid.

rtg
Daniel Chen - Oct. 1, 2009, 1:33 p.m.
Takashi says the codec parser doesn't handle this properly, so the fix for
LL is likely to revert this patch, which has already been merged into
sound-2.6. (2.6.32-rc1 also has inaudible playback without this quirk.)

On Oct 1, 2009 9:28 AM, "Tim Gardner" <tim.gardner@canonical.com> wrote:

Manoj Iyer wrote: > This patch enables sound on Toshiba NB200/205 netbooks.
I submitted the > patch...
Now that Andy has mainline 2.6.32-rc1 building, it shouldn't take too
long to test if this is already fixed upstream. In which case its a
simple cherry-pick (hopefully) v.s. another SAUCE patch that we have to
worry about getting into Lucid.

rtg
--
Tim Gardner tim.gardner@canonical.com

-- kernel-team mailing list kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo...
Manoj Iyer - Oct. 1, 2009, 2:10 p.m.
Takashi applied the patch as a quick fix to the problem, so it should be a 
cherry pick.

On Thu, 1 Oct 2009, Tim Gardner wrote:

> Manoj Iyer wrote:
>> This patch enables sound on Toshiba NB200/205 netbooks. I submitted the
>> patch upstream, and maintainer wants me to test 2.6.32-rc1, as the recent
>> fixes might have fixed this without the quirk. Submitting to the list in
>> case we need it sooner.
>>
>> From a09d48287041b355400372029415ac163179b829 Mon Sep 17 00:00:00 2001
>> From: Manoj Iyer <manjo@hungry.(none)>
>> Date: Wed, 30 Sep 2009 16:44:06 -0500
>> Subject: [PATCH] UBUNTU: SAUCE: Added quirk to enable sound on Toshiba NB200
>>
>> Submitted patch upstream.
>>
>> BugLink: http://bugs.launchpad.net/bugs/438318
>>
>> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
>> ---
>>   sound/pci/hda/patch_realtek.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 30eeb30..713bf69 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -16876,6 +16876,7 @@ static struct snd_pci_quirk alc662_cfg_tbl[] = {
>>   	SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_ECS),
>>   	SND_PCI_QUIRK(0x105b, 0x0d47, "Foxconn 45CMX/45GMX/45CMX-K",
>>   		      ALC662_3ST_6ch_DIG),
>> +	SND_PCI_QUIRK(0x1179, 0xff6e, "Toshiba NB200", ALC663_ASUS_MODE4),
>>   	SND_PCI_QUIRK(0x144d, 0xca00, "Samsung NC10", ALC272_SAMSUNG_NC10),
>>   	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte 945GCM-S2L",
>>   		      ALC662_3ST_6ch_DIG),
>
> Now that Andy has mainline 2.6.32-rc1 building, it shouldn't take too
> long to test if this is already fixed upstream. In which case its a
> simple cherry-pick (hopefully) v.s. another SAUCE patch that we have to
> worry about getting into Lucid.
>
> rtg
> -- 
> Tim Gardner tim.gardner@canonical.com
>
Tim Gardner - Oct. 1, 2009, 3:44 p.m.
Bug me again when Linus merges it from Takashi's tree.

manoj.iyer@canonical.com wrote:
> 
> Takashi applied the patch as a quick fix to the problem, so it should be
> a cherry pick.
> 
> On Thu, 1 Oct 2009, Tim Gardner wrote:
> 
>> Manoj Iyer wrote:
>>> This patch enables sound on Toshiba NB200/205 netbooks. I submitted the
>>> patch upstream, and maintainer wants me to test 2.6.32-rc1, as the
>>> recent
>>> fixes might have fixed this without the quirk. Submitting to the list in
>>> case we need it sooner.
>>>
>>> From a09d48287041b355400372029415ac163179b829 Mon Sep 17 00:00:00 2001
>>> From: Manoj Iyer <manjo@hungry.(none)>
>>> Date: Wed, 30 Sep 2009 16:44:06 -0500
>>> Subject: [PATCH] UBUNTU: SAUCE: Added quirk to enable sound on
>>> Toshiba NB200
>>>
>>> Submitted patch upstream.
>>>
>>> BugLink: http://bugs.launchpad.net/bugs/438318
>>>
>>> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
>>> ---
>>>   sound/pci/hda/patch_realtek.c |    1 +
>>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c
>>> b/sound/pci/hda/patch_realtek.c
>>> index 30eeb30..713bf69 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -16876,6 +16876,7 @@ static struct snd_pci_quirk alc662_cfg_tbl[] = {
>>>       SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_ECS),
>>>       SND_PCI_QUIRK(0x105b, 0x0d47, "Foxconn 45CMX/45GMX/45CMX-K",
>>>                 ALC662_3ST_6ch_DIG),
>>> +    SND_PCI_QUIRK(0x1179, 0xff6e, "Toshiba NB200", ALC663_ASUS_MODE4),
>>>       SND_PCI_QUIRK(0x144d, 0xca00, "Samsung NC10",
>>> ALC272_SAMSUNG_NC10),
>>>       SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte 945GCM-S2L",
>>>                 ALC662_3ST_6ch_DIG),
>>
>> Now that Andy has mainline 2.6.32-rc1 building, it shouldn't take too
>> long to test if this is already fixed upstream. In which case its a
>> simple cherry-pick (hopefully) v.s. another SAUCE patch that we have to
>> worry about getting into Lucid.
>>
>> rtg
>> -- 
>> Tim Gardner tim.gardner@canonical.com
>>
Tim Gardner - Oct. 1, 2009, 3:52 p.m.
oh, hell. applied (after re-adding BugLink to the commit log). You
should ask Takashi why he stripped it out of his commit.

rtg

manoj.iyer@canonical.com wrote:
> 
> Takashi applied the patch as a quick fix to the problem, so it should be
> a cherry pick.
> 
> On Thu, 1 Oct 2009, Tim Gardner wrote:
> 
>> Manoj Iyer wrote:
>>> This patch enables sound on Toshiba NB200/205 netbooks. I submitted the
>>> patch upstream, and maintainer wants me to test 2.6.32-rc1, as the
>>> recent
>>> fixes might have fixed this without the quirk. Submitting to the list in
>>> case we need it sooner.
>>>
>>> From a09d48287041b355400372029415ac163179b829 Mon Sep 17 00:00:00 2001
>>> From: Manoj Iyer <manjo@hungry.(none)>
>>> Date: Wed, 30 Sep 2009 16:44:06 -0500
>>> Subject: [PATCH] UBUNTU: SAUCE: Added quirk to enable sound on
>>> Toshiba NB200
>>>
>>> Submitted patch upstream.
>>>
>>> BugLink: http://bugs.launchpad.net/bugs/438318
>>>
>>> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com>
>>> ---
>>>   sound/pci/hda/patch_realtek.c |    1 +
>>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c
>>> b/sound/pci/hda/patch_realtek.c
>>> index 30eeb30..713bf69 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -16876,6 +16876,7 @@ static struct snd_pci_quirk alc662_cfg_tbl[] = {
>>>       SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_ECS),
>>>       SND_PCI_QUIRK(0x105b, 0x0d47, "Foxconn 45CMX/45GMX/45CMX-K",
>>>                 ALC662_3ST_6ch_DIG),
>>> +    SND_PCI_QUIRK(0x1179, 0xff6e, "Toshiba NB200", ALC663_ASUS_MODE4),
>>>       SND_PCI_QUIRK(0x144d, 0xca00, "Samsung NC10",
>>> ALC272_SAMSUNG_NC10),
>>>       SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte 945GCM-S2L",
>>>                 ALC662_3ST_6ch_DIG),
>>
>> Now that Andy has mainline 2.6.32-rc1 building, it shouldn't take too
>> long to test if this is already fixed upstream. In which case its a
>> simple cherry-pick (hopefully) v.s. another SAUCE patch that we have to
>> worry about getting into Lucid.
>>
>> rtg
>> -- 
>> Tim Gardner tim.gardner@canonical.com
>>

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 30eeb30..713bf69 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -16876,6 +16876,7 @@  static struct snd_pci_quirk alc662_cfg_tbl[] = {
  	SND_PCI_QUIRK(0x105b, 0x0cd6, "Foxconn", ALC662_ECS),
  	SND_PCI_QUIRK(0x105b, 0x0d47, "Foxconn 45CMX/45GMX/45CMX-K",
  		      ALC662_3ST_6ch_DIG),
+	SND_PCI_QUIRK(0x1179, 0xff6e, "Toshiba NB200", ALC663_ASUS_MODE4),
  	SND_PCI_QUIRK(0x144d, 0xca00, "Samsung NC10", ALC272_SAMSUNG_NC10),
  	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte 945GCM-S2L",
  		      ALC662_3ST_6ch_DIG),