| Message ID | 1399395136-12139-1-git-send-email-zonque@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
2014-05-06 9:52 GMT-07:00 Daniel Mack <zonque@gmail.com>: > If CONFIG_OF is not set, make of_mdiobus_register() call > mdiobus_register() instead of returning -ENOSYS. > > This way, we can just call of_mdiobus_register() from all DT-enabled > drivers to handle the compat cases. > > Signed-off-by: Daniel Mack <zonque@gmail.com> > Suggested-by: Florian Fainelli <f.fainelli@gmail.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com> > --- > include/linux/of_mdio.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h > index 6fe8464..881a7c3 100644 > --- a/include/linux/of_mdio.h > +++ b/include/linux/of_mdio.h > @@ -31,7 +31,12 @@ extern struct mii_bus *of_mdio_find_bus(struct device_node *mdio_np); > #else /* CONFIG_OF */ > static inline int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) > { > - return -ENOSYS; > + /* > + * Fall back to the non-DT function to register a bus. > + * This way, we don't have to keep compat bits around in drivers. > + */ > + > + return mdiobus_register(mdio); > } > > static inline struct phy_device *of_phy_find_device(struct device_node *phy_np) > -- > 1.9.0 >
On Tuesday 06 May 2014 10:22 PM, Daniel Mack wrote: > If CONFIG_OF is not set, make of_mdiobus_register() call > mdiobus_register() instead of returning -ENOSYS. > > This way, we can just call of_mdiobus_register() from all DT-enabled > drivers to handle the compat cases. > > Signed-off-by: Daniel Mack <zonque@gmail.com> > Suggested-by: Florian Fainelli <f.fainelli@gmail.com> > --- Acked-by: Mugunthan V N <mugunthanvnm@ti.com> Regards Mugunthan V N -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Daniel Mack <zonque@gmail.com> Date: Tue, 6 May 2014 18:52:16 +0200 > If CONFIG_OF is not set, make of_mdiobus_register() call > mdiobus_register() instead of returning -ENOSYS. > > This way, we can just call of_mdiobus_register() from all DT-enabled > drivers to handle the compat cases. > > Signed-off-by: Daniel Mack <zonque@gmail.com> > Suggested-by: Florian Fainelli <f.fainelli@gmail.com> Applied, thanks Daniel. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/of_mdio.h b/include/linux/of_mdio.h index 6fe8464..881a7c3 100644 --- a/include/linux/of_mdio.h +++ b/include/linux/of_mdio.h @@ -31,7 +31,12 @@ extern struct mii_bus *of_mdio_find_bus(struct device_node *mdio_np); #else /* CONFIG_OF */ static inline int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) { - return -ENOSYS; + /* + * Fall back to the non-DT function to register a bus. + * This way, we don't have to keep compat bits around in drivers. + */ + + return mdiobus_register(mdio); } static inline struct phy_device *of_phy_find_device(struct device_node *phy_np)
If CONFIG_OF is not set, make of_mdiobus_register() call mdiobus_register() instead of returning -ENOSYS. This way, we can just call of_mdiobus_register() from all DT-enabled drivers to handle the compat cases. Signed-off-by: Daniel Mack <zonque@gmail.com> Suggested-by: Florian Fainelli <f.fainelli@gmail.com> --- include/linux/of_mdio.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)