From patchwork Tue May 6 15:35:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Kluchnikov X-Patchwork-Id: 346245 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D090F1413BB for ; Wed, 7 May 2014 01:43:37 +1000 (EST) Received: from localhost ([127.0.0.1] helo=ganesha.gnumonks.org) by ganesha.gnumonks.org with esmtp (Exim 4.72) (envelope-from ) id 1WhhWe-0006XE-RE; Tue, 06 May 2014 17:43:25 +0200 Received: from mail-lb0-x234.google.com ([2a00:1450:4010:c04::234]) by ganesha.gnumonks.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.72) (envelope-from ) id 1WhhPm-0005oV-0j for openbsc@lists.osmocom.org; Tue, 06 May 2014 17:36:24 +0200 Received: by mail-lb0-f180.google.com with SMTP id p9so2710247lbv.11 for ; Tue, 06 May 2014 08:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:in-reply-to:references; bh=Br0p5UjPLhOczcoSV/cI3tR+Xs/1KX7FzHS5jRXyjzw=; b=b8W54Mh+Zc6J1HCFTBconhXQdwpgIIVxAGsInQotcDKmB6wNORNaHjnSP13wxvhwJs ONXxnb4aLpe4oiJRfE3TdDIibhcNtMBRJ2PHCiyD7x3B8hHOGXspPguhZuZl20Rp6qvT laWqb4HSakgEYq09URFTMUI0JIEsTV76+Ukx9sANJML8l3uzplVYke8Tf8zUAtx+OThc 0qUDPGSconJjmyHNNKf49VbFY6YX1ZE/9pxC3JGFmzMucWn+nZKml9qAXhcVA1ZUpuJt 2ZVt/Z6TZQXbg3D3Bnld5J6GHQrdixkNsc8QjOUO2/MFhYUuTd8Q7PmDTMgAn9/clXMi 7lhg== X-Received: by 10.112.137.39 with SMTP id qf7mr32123708lbb.18.1399390577305; Tue, 06 May 2014 08:36:17 -0700 (PDT) Received: from kluchnikov.neuronspace.ru ([84.253.75.222]) by mx.google.com with ESMTPSA id jp6sm13898997lbc.15.2014.05.06.08.36.14 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 06 May 2014 08:36:15 -0700 (PDT) From: Ivan Kluchnikov To: openbsc@lists.osmocom.org Subject: [PATCH 3/3] nitb/ctrl: Add ctrl command to get/set arfcn Date: Tue, 6 May 2014 19:35:59 +0400 Message-Id: <1399390559-22655-3-git-send-email-kluchnikovi@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1399390559-22655-1-git-send-email-kluchnikovi@gmail.com> References: <1399390559-22655-1-git-send-email-kluchnikovi@gmail.com> X-Spam-Score: -0.0 (/) X-BeenThere: openbsc@lists.osmocom.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Development of the OpenBSC GSM base station controller List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openbsc-bounces@lists.osmocom.org Errors-To: openbsc-bounces@lists.osmocom.org --- openbsc/src/libbsc/bsc_ctrl_commands.c | 2 ++ openbsc/tests/ctrl_test_runner.py | 15 +++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/openbsc/src/libbsc/bsc_ctrl_commands.c b/openbsc/src/libbsc/bsc_ctrl_commands.c index bbd4fbd..d1edf29 100644 --- a/openbsc/src/libbsc/bsc_ctrl_commands.c +++ b/openbsc/src/libbsc/bsc_ctrl_commands.c @@ -253,6 +253,7 @@ static int set_trx_max_power(struct ctrl_cmd *cmd, void *_data) return get_trx_max_power(cmd, _data); } CTRL_CMD_DEFINE(trx_max_power, "max-power-reduction"); +CTRL_CMD_DEFINE_RANGE(trx_arfcn, "arfcn", struct gsm_bts_trx, arfcn, 0, 1023); int bsc_base_ctrl_cmds_install(void) { @@ -268,5 +269,6 @@ int bsc_base_ctrl_cmds_install(void) rc |= ctrl_cmd_install(CTRL_NODE_BTS, &cmd_bts_band); rc |= ctrl_cmd_install(CTRL_NODE_TRX, &cmd_trx_max_power); + rc |= ctrl_cmd_install(CTRL_NODE_TRX, &cmd_trx_arfcn); return rc; } diff --git a/openbsc/tests/ctrl_test_runner.py b/openbsc/tests/ctrl_test_runner.py index 243ac0f..0dc9800 100644 --- a/openbsc/tests/ctrl_test_runner.py +++ b/openbsc/tests/ctrl_test_runner.py @@ -399,6 +399,21 @@ class TestCtrlNITB(TestCtrlBase): self.assertEquals(r['mtype'], 'ERROR') self.assertEquals(r['error'], 'Value failed verification.') + def testTrxArfcn(self): + r = self.do_set('bts.0.trx.0.arfcn', '51') + self.assertEquals(r['mtype'], 'SET_REPLY') + self.assertEquals(r['var'], 'bts.0.trx.0.arfcn') + self.assertEquals(r['value'], '51') + + r = self.do_get('bts.0.trx.0.arfcn') + self.assertEquals(r['mtype'], 'GET_REPLY') + self.assertEquals(r['var'], 'bts.0.trx.0.arfcn') + self.assertEquals(r['value'], '51') + + r = self.do_set('bts.0.trx.0.arfcn', '3000') + self.assertEquals(r['mtype'], 'ERROR') + self.assertEquals(r['error'], 'Input not within the range') + def testSubscriberAddRemove(self): r = self.do_set('subscriber-modify-v1', '2620345,445566') self.assertEquals(r['mtype'], 'SET_REPLY')