Patchwork [v2] freetype: freetype-patch: depends on host-automake

login
register
mail settings
Submitter Fabio Porcedda
Date May 5, 2014, 2:08 p.m.
Message ID <1399298902-19863-1-git-send-email-fabio.porcedda@gmail.com>
Download mbox | patch
Permalink /patch/345730/
State Accepted
Commit c965ad639f3e6c8c224ae5c280ae0be8356794db
Headers show

Comments

Fabio Porcedda - May 5, 2014, 2:08 p.m.
The "make freetype-patch" fails because does not found autogen.sh,
because autogen.sh available only for the configure stage.
To fix this add host-automake as a prerequisite to freetype-patch.

This change also fix the support to top-level parallel make.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Cc: Samuel Martin <s.martin49@gmail.com>
---
v2:
 - Add host-automake as a order-only-prerequisite because it is a
   phony target.

 package/freetype/freetype.mk | 4 ++++
 1 file changed, 4 insertions(+)
Fabio Porcedda - May 5, 2014, 2:11 p.m.
On Mon, May 5, 2014 at 4:08 PM, Fabio Porcedda <fabio.porcedda@gmail.com> wrote:
> The "make freetype-patch" fails because does not found autogen.sh,
> because autogen.sh available only for the configure stage.
> To fix this add host-automake as a prerequisite to freetype-patch.
>
> This change also fix the support to top-level parallel make.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> Cc: Samuel Martin <s.martin49@gmail.com>
> ---
> v2:
>  - Add host-automake as a order-only-prerequisite because it is a
>    phony target.
>
>  package/freetype/freetype.mk | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/package/freetype/freetype.mk b/package/freetype/freetype.mk
> index c7c9a06..a6ae0a0 100644
> --- a/package/freetype/freetype.mk
> +++ b/package/freetype/freetype.mk
> @@ -83,3 +83,7 @@ HOST_FREETYPE_POST_INSTALL_HOOKS += HOST_FREETYPE_FIX_FREETYPE_INCLUDE
>
>  $(eval $(autotools-package))
>  $(eval $(host-autotools-package))
> +
> +# freetype-patch uses autogen.sh so add it as a order-only-prerequisite
> +# because it is a phony target.
> +$(FREETYPE_TARGET_PATCH): | host-automake
> --
> 1.9.1
>

I've sent an updated patch:

http://patchwork.ozlabs.org/patch/345730/

Regards
Peter Korsgaard - May 11, 2014, 9:17 p.m.
>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

 > The "make freetype-patch" fails because does not found autogen.sh,
 > because autogen.sh available only for the configure stage.
 > To fix this add host-automake as a prerequisite to freetype-patch.

 > This change also fix the support to top-level parallel make.

 > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
 > Cc: Samuel Martin <s.martin49@gmail.com>
 > ---
 > v2:
 >  - Add host-automake as a order-only-prerequisite because it is a
 >    phony target.

Committed, thanks.

Patch

diff --git a/package/freetype/freetype.mk b/package/freetype/freetype.mk
index c7c9a06..a6ae0a0 100644
--- a/package/freetype/freetype.mk
+++ b/package/freetype/freetype.mk
@@ -83,3 +83,7 @@  HOST_FREETYPE_POST_INSTALL_HOOKS += HOST_FREETYPE_FIX_FREETYPE_INCLUDE
 
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
+
+# freetype-patch uses autogen.sh so add it as a order-only-prerequisite
+# because it is a phony target.
+$(FREETYPE_TARGET_PATCH): | host-automake