Patchwork libenca: Move build host tool to PRE_BUILD_HOOKS

login
register
mail settings
Submitter Maxime Hadjinlian
Date May 5, 2014, 1:24 p.m.
Message ID <1399296247-26320-1-git-send-email-maxime.hadjinlian@gmail.com>
Download mbox | patch
Permalink /patch/345722/
State Accepted
Headers show

Comments

Maxime Hadjinlian - May 5, 2014, 1:24 p.m.
The make_hash host tool, should be built during a PRE_BUILD_HOOKS and
not a POST_CONFIGURE_HOOKS.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/libenca/libenca.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Maxime Hadjinlian - May 5, 2014, 1:25 p.m.
Note that this patch can only be applied if
http://patchwork.ozlabs.org/patch/345719/ is applied first.
I can resend as a series if it's needed.

On Mon, May 5, 2014 at 3:24 PM, Maxime Hadjinlian
<maxime.hadjinlian@gmail.com> wrote:
> The make_hash host tool, should be built during a PRE_BUILD_HOOKS and
> not a POST_CONFIGURE_HOOKS.
>
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  package/libenca/libenca.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libenca/libenca.mk b/package/libenca/libenca.mk
> index d998c66..66fcfaa 100644
> --- a/package/libenca/libenca.mk
> +++ b/package/libenca/libenca.mk
> @@ -21,6 +21,6 @@ define LIBENCA_MAKE_HOST_TOOL
>         $(MAKE) -C $(@D)/tools $(HOST_CONFIGURE_OPTS) make_hash
>  endef
>
> -LIBENCA_POST_CONFIGURE_HOOKS += LIBENCA_MAKE_HOST_TOOL
> +LIBENCA_PRE_BUILD_HOOKS += LIBENCA_MAKE_HOST_TOOL
>
>  $(eval $(autotools-package))
> --
> 1.9.2
>
Peter Korsgaard - May 8, 2014, 8:02 p.m.
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 > The make_hash host tool, should be built during a PRE_BUILD_HOOKS and
 > not a POST_CONFIGURE_HOOKS.

 > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

Committed, thanks.

Patch

diff --git a/package/libenca/libenca.mk b/package/libenca/libenca.mk
index d998c66..66fcfaa 100644
--- a/package/libenca/libenca.mk
+++ b/package/libenca/libenca.mk
@@ -21,6 +21,6 @@  define LIBENCA_MAKE_HOST_TOOL
 	$(MAKE) -C $(@D)/tools $(HOST_CONFIGURE_OPTS) make_hash
 endef
 
-LIBENCA_POST_CONFIGURE_HOOKS += LIBENCA_MAKE_HOST_TOOL
+LIBENCA_PRE_BUILD_HOOKS += LIBENCA_MAKE_HOST_TOOL
 
 $(eval $(autotools-package))