From patchwork Mon May 5 10:01:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Porcedda X-Patchwork-Id: 345652 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 6A771140E3A for ; Mon, 5 May 2014 20:01:35 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 9C298321A6; Mon, 5 May 2014 10:01:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fY0QK+L5u9yw; Mon, 5 May 2014 10:01:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 0F4BD321CF; Mon, 5 May 2014 10:01:31 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 13CCD1BF992 for ; Mon, 5 May 2014 10:01:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 0EC05879C5 for ; Mon, 5 May 2014 10:01:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4VjWAS6-7yGA for ; Mon, 5 May 2014 10:01:29 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by hemlock.osuosl.org (Postfix) with ESMTPS id 8AB40877C6 for ; Mon, 5 May 2014 10:01:29 +0000 (UTC) Received: by mail-ob0-f178.google.com with SMTP id va2so4859800obc.37 for ; Mon, 05 May 2014 03:01:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=FPNZP3ofV/9fgV9DHnASJObCFLfx7F6hzGLyO9DZtVc=; b=QQBCkL2O2MJAQgnX8pMDHvwb6+q+/tvnajHRwbbtJhJuCfpHNFaNShh2emXR5u3QmL VNGyN33T3K7TnKhkNiTu8ouBEcpiIxOMq2J3Px4AQXA6LfaRj2QqYWzrkbsR2Ef114/x FyIzVpT/dCvw058d48Xbv3y/UOWCZnDTkfOfNS7H6vmkZkQBDpegJ2MBRbkc6Zghm6ov ddhbgo+I770aMHvtFH+8jGdz2MvpdJqdeWnOEBoXscabhyPeULHL8DKDIgz1hPviq7hT VaDeEH4XhxOCAdVLg1+WDIL8AWBZf/0E4Lk8M0PLQ/eufNwkOqhDtYb3u5EUnPvUyBAJ wizg== X-Received: by 10.60.58.7 with SMTP id m7mr1244935oeq.59.1399284088669; Mon, 05 May 2014 03:01:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.76.176.39 with HTTP; Mon, 5 May 2014 03:01:08 -0700 (PDT) In-Reply-To: References: <1399282934-14517-1-git-send-email-fabio.porcedda@gmail.com> From: Fabio Porcedda Date: Mon, 5 May 2014 12:01:08 +0200 Message-ID: To: Samuel Martin Cc: Buildroot Mailing List Subject: Re: [Buildroot] [PATCH] freetype: freetype-patch: depends on host-automake X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net On Mon, May 5, 2014 at 11:55 AM, Samuel Martin wrote: > Hi Fabio, all, > > On Mon, May 5, 2014 at 11:42 AM, Fabio Porcedda > wrote: >> The "make freetype-patch" fails because does not found autogen.sh, >> because autogen.sh available only for the configure stage. >> To fix this add host-automake as a prerequisite to freetype-patch too. >> >> This also fix the support to top-level parallel make. >> >> Signed-off-by: Fabio Porcedda >> --- >> package/freetype/freetype.mk | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/package/freetype/freetype.mk b/package/freetype/freetype.mk >> index c7c9a06..33a6317 100644 >> --- a/package/freetype/freetype.mk >> +++ b/package/freetype/freetype.mk >> @@ -83,3 +83,6 @@ HOST_FREETYPE_POST_INSTALL_HOOKS += HOST_FREETYPE_FIX_FREETYPE_INCLUDE >> >> $(eval $(autotools-package)) >> $(eval $(host-autotools-package)) >> + >> +# freetype-patch uses autogen.sh so add it as a prerequisite >> +$(FREETYPE_TARGET_PATCH): host-automake > > It's an unusual way of doing this! > How about moving the *FREETYPE_RUN_AUTOGEN hook in > *FREETYPE_PRE_CONFIGURE_HOOKS? Unfortunately that's alone does not work because LIBTOOL_PATCH_HOOK it's going to fail, the only solution i've found is to move LIBTOOL_PATCH_HOOK to PRE_CONFIGURE too, but i'm not sure is it fine to do that, what do you think about that? patch: Regards diff --git a/package/freetype/freetype.mk b/package/freetype/freetype.mk index c7c9a06..8aac8a2 100644 --- a/package/freetype/freetype.mk +++ b/package/freetype/freetype.mk @@ -25,8 +25,8 @@ HOST_FREETYPE_CONF_OPT = --without-zlib --without-bzip2 --without-png define FREETYPE_RUN_AUTOGEN cd $(@D) && PATH=$(BR_PATH) ./autogen.sh endef -FREETYPE_POST_PATCH_HOOKS += FREETYPE_RUN_AUTOGEN -HOST_FREETYPE_POST_PATCH_HOOKS += FREETYPE_RUN_AUTOGEN +FREETYPE_PRE_CONFIGURE_HOOKS += FREETYPE_RUN_AUTOGEN +HOST_FREETYPE_PRE_CONFIGURE_HOOKS += FREETYPE_RUN_AUTOGEN FREETYPE_DEPENDENCIES += host-automake host-autoconf host-libtool HOST_FREETYPE_DEPENDENCIES += host-automake host-autoconf host-libtool diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk index a646612..38b8c4c 100644 --- a/package/pkg-autotools.mk +++ b/package/pkg-autotools.mk @@ -193,7 +193,7 @@ endef # default values are not evaluated yet, so don't rely on this defaulting to YES ifneq ($$($(2)_LIBTOOL_PATCH),NO) -$(2)_POST_PATCH_HOOKS += LIBTOOL_PATCH_HOOK +$(2)_PRE_CONFIGURE_HOOKS += LIBTOOL_PATCH_HOOK endif #