From patchwork Fri May 2 08:24:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 344896 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3B81514012F for ; Fri, 2 May 2014 18:24:23 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :content-type:content-transfer-encoding; q=dns; s=default; b=PvZ iiVUZGoNiYcW0poxT3fiNB3gMjkP874HAgGo7/VRbQyI3WHKF5qR6HOySz4ADwY8 +nfC30mnqlJMzEdU1JhSyAPA7Y5FDJ8j2r0+wBNxpVrZB4QRFmxsLl1c//cgguzi eJgXQ2q9K63DQ5qMYfg87rF1102xEp+7stzrdA/0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:message-id:date:from:mime-version:to:subject :content-type:content-transfer-encoding; s=default; bh=O+0p2zV8E TwlMe/EAM7VXLp/ZN0=; b=CaoymrqoDTc9VPDxjVeYgw7KhhmgJSxRr3eWwtbLk L766TOUwY1l1f5wQv7wmpKcSwROaM8WrlkBW5Z++o6/zW0GFIDww+MJxzlURIJMO 62+J2kb64hBy5jcQWvILtlDHODQ+d9BaHCWDwsetWcjj/scctsoUqCwcw4D9DFHV gw= Received: (qmail 25734 invoked by alias); 2 May 2014 08:24:17 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 25722 invoked by uid 89); 2 May 2014 08:24:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <5363562D.6030902@redhat.com> Date: Fri, 02 May 2014 04:24:13 -0400 From: "Carlos O'Donell" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: GNU C Library , Roland McGrath Subject: [WIP] Fix HAVE_CONFIG_H -Wundef warnings. Roland, Is fixing the HAVE_CONFIG_H -Wundef warnings as easy as this? --- Followed by the mechanical change of all the `#idfef HAVE_CONFIG_H` to `#if HAVE_CONFIG_H`. Then verify the built binaries are identical and pass the testsuite? We always create a config.h for glibc so this looks correct. I don't want to waste my time fixing all of this if I've got it wrong. Cheers, Carlos. diff --git a/Makeconfig b/Makeconfig index f965398..64b64fc 100644 --- a/Makeconfig +++ b/Makeconfig @@ -1081,6 +1081,9 @@ endif sysd-rules-targets := $(sort $(foreach p,$(sysd-rules-patterns),\ $(firstword $(subst :, ,$p)))) +# We always configure glibc such that config.h is available. +defines += -DHAVE_CONFIG_H=1 + # A sysdeps Makeconfig fragment may set libc-reentrant to yes. ifeq (yes,$(libc-reentrant)) defines += -D_LIBC_REENTRANT