Patchwork [1/3] host-xxd: new package

login
register
mail settings
Submitter Ryan Barnett
Date May 1, 2014, 7:32 p.m.
Message ID <1398972731-20680-2-git-send-email-rjbarnet@rockwellcollins.com>
Download mbox | patch
Permalink /patch/344795/
State New
Headers show

Comments

Ryan Barnett - May 1, 2014, 7:32 p.m.
Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/Config.in.host     |  1 +
 package/xxd/Config.in.host |  6 ++++++
 package/xxd/xxd.mk         | 20 ++++++++++++++++++++
 3 files changed, 27 insertions(+)
 create mode 100644 package/xxd/Config.in.host
 create mode 100644 package/xxd/xxd.mk
Thomas De Schampheleire - May 1, 2014, 7:56 p.m.
Hi Ryan,

Ryan Barnett <rjbarnet@rockwellcollins.com> schreef:
>Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
>Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>---
> package/Config.in.host     |  1 +
> package/xxd/Config.in.host |  6 ++++++
> package/xxd/xxd.mk         | 20 ++++++++++++++++++++
> 3 files changed, 27 insertions(+)
> create mode 100644 package/xxd/Config.in.host
> create mode 100644 package/xxd/xxd.mk
>
>diff --git a/package/Config.in.host b/package/Config.in.host
>index c6997e9..5d5b645 100644
>--- a/package/Config.in.host
>+++ b/package/Config.in.host
>@@ -18,5 +18,6 @@ source "package/squashfs/Config.in.host"
> source "package/sunxi-tools/Config.in.host"
> source "package/uboot-tools/Config.in.host"
> source "package/util-linux/Config.in.host"
>+source "package/xxd/Config.in.host"
> 
> endmenu
>diff --git a/package/xxd/Config.in.host b/package/xxd/Config.in.host
>new file mode 100644
>index 0000000..c2cddde
>--- /dev/null
>+++ b/package/xxd/Config.in.host
>@@ -0,0 +1,6 @@
>+config BR2_PACKAGE_XXD
>+	bool "host xxd"
>+	help
>+	  xxd creates a hex dump of a given file or standard input
>+
>+	  http://linux.die.net/man/1/xxd

Normally we specify a project site here, no man page. Is there no such site available?

>diff --git a/package/xxd/xxd.mk b/package/xxd/xxd.mk
>new file mode 100644
>index 0000000..a960f86
>--- /dev/null
>+++ b/package/xxd/xxd.mk
>@@ -0,0 +1,20 @@
>+################################################################################
>+#
>+# xxd
>+#
>+################################################################################
>+
>+XXD_VERSION = 1.10
>+XXD_SITE    = http://grail.cba.csuohio.edu/~somos

Extra whitespace before = should be removed.

>+XXD_LICENSE = Public Domain
>+XXD_LICENSE_FILES = xxd.c
>+
>+define HOST_XXD_BUILD_CMDS
>+	$(HOST_MAKE_ENV) $(MAKE) -C $(@D)
>+endef
>+
>+define HOST_XXD_INSTALL_CMDS
>+	$(INSTALL) -m 0755 -D $(@D)/xxd $(HOST_DIR)/usr/bin/xxd
>+endef
>+
>+$(eval $(host-generic-package))

Best regards,
Thomas
Ryan Barnett - May 1, 2014, 8:33 p.m.
Thomas,

Thomas De Schampheleire <patrickdepinguin@gmail.com> wrote on 05/01/2014 
02:56:37 PM:

> Hi Ryan,
> >diff --git a/package/xxd/Config.in.host b/package/xxd/Config.in.host
> >new file mode 100644
> >index 0000000..c2cddde
> >--- /dev/null
> >+++ b/package/xxd/Config.in.host
> >@@ -0,0 +1,6 @@
> >+config BR2_PACKAGE_XXD
> >+   bool "host xxd"
> >+   help
> >+     xxd creates a hex dump of a given file or standard input
> >+
> >+     http://linux.die.net/man/1/xxd
> 
> Normally we specify a project site here, no man page. Is there no such
> site available?

Yes that is correct. I could not find an official project website since 
this tool is public domain. The most useful site that I found for this 
package the man page.

Any other thoughts on what this should be?

> 
> >diff --git a/package/xxd/xxd.mk b/package/xxd/xxd.mk
> >new file mode 100644
> >index 0000000..a960f86
> >--- /dev/null
> >+++ b/package/xxd/xxd.mk
> >@@ -0,0 +1,20 @@
> >
> 
+################################################################################
> >+#
> >+# xxd
> >+#
> >
> 
+################################################################################
> >+
> >+XXD_VERSION = 1.10
> >+XXD_SITE    = http://grail.cba.csuohio.edu/~somos
> 
> Extra whitespace before = should be removed.

Will remove.
 
> >+XXD_LICENSE = Public Domain
> >+XXD_LICENSE_FILES = xxd.c
> >+
> >+define HOST_XXD_BUILD_CMDS
> >+   $(HOST_MAKE_ENV) $(MAKE) -C $(@D)
> >+endef
> >+
> >+define HOST_XXD_INSTALL_CMDS
> >+   $(INSTALL) -m 0755 -D $(@D)/xxd $(HOST_DIR)/usr/bin/xxd
> >+endef
> >+
> >+$(eval $(host-generic-package))
> 
> Best regards,
> Thomas

Thanks,
-Ryan

Patch

diff --git a/package/Config.in.host b/package/Config.in.host
index c6997e9..5d5b645 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -18,5 +18,6 @@  source "package/squashfs/Config.in.host"
 source "package/sunxi-tools/Config.in.host"
 source "package/uboot-tools/Config.in.host"
 source "package/util-linux/Config.in.host"
+source "package/xxd/Config.in.host"
 
 endmenu
diff --git a/package/xxd/Config.in.host b/package/xxd/Config.in.host
new file mode 100644
index 0000000..c2cddde
--- /dev/null
+++ b/package/xxd/Config.in.host
@@ -0,0 +1,6 @@ 
+config BR2_PACKAGE_XXD
+	bool "host xxd"
+	help
+	  xxd creates a hex dump of a given file or standard input
+
+	  http://linux.die.net/man/1/xxd
diff --git a/package/xxd/xxd.mk b/package/xxd/xxd.mk
new file mode 100644
index 0000000..a960f86
--- /dev/null
+++ b/package/xxd/xxd.mk
@@ -0,0 +1,20 @@ 
+################################################################################
+#
+# xxd
+#
+################################################################################
+
+XXD_VERSION = 1.10
+XXD_SITE    = http://grail.cba.csuohio.edu/~somos
+XXD_LICENSE = Public Domain
+XXD_LICENSE_FILES = xxd.c
+
+define HOST_XXD_BUILD_CMDS
+	$(HOST_MAKE_ENV) $(MAKE) -C $(@D)
+endef
+
+define HOST_XXD_INSTALL_CMDS
+	$(INSTALL) -m 0755 -D $(@D)/xxd $(HOST_DIR)/usr/bin/xxd
+endef
+
+$(eval $(host-generic-package))