| Message ID | 1398952881-27828-3-git-send-email-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Headers | show |
On 05/01/2014 10:01 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Coverity scan found a memory leak on data returned from > fwts_get(). This needs to be free'd. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_button.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/lib/src/fwts_button.c b/src/lib/src/fwts_button.c > index 2202c03..6a34eb7 100644 > --- a/src/lib/src/fwts_button.c > +++ b/src/lib/src/fwts_button.c > @@ -86,6 +86,7 @@ static int fwts_button_match_state_proc( > (*matched)++; > else > (*not_matched)++; > + free(data); > } > } > } while (entry); > Acked-by: Ivan Hu <ivan.hu@canonical.com>
On 05/01/2014 10:01 PM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Coverity scan found a memory leak on data returned from > fwts_get(). This needs to be free'd. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > src/lib/src/fwts_button.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/lib/src/fwts_button.c b/src/lib/src/fwts_button.c > index 2202c03..6a34eb7 100644 > --- a/src/lib/src/fwts_button.c > +++ b/src/lib/src/fwts_button.c > @@ -86,6 +86,7 @@ static int fwts_button_match_state_proc( > (*matched)++; > else > (*not_matched)++; > + free(data); > } > } > } while (entry); > Acked-by: Alex Hung <alex.hung@canonical.com>
diff --git a/src/lib/src/fwts_button.c b/src/lib/src/fwts_button.c index 2202c03..6a34eb7 100644 --- a/src/lib/src/fwts_button.c +++ b/src/lib/src/fwts_button.c @@ -86,6 +86,7 @@ static int fwts_button_match_state_proc( (*matched)++; else (*not_matched)++; + free(data); } } } while (entry);