From patchwork Mon Apr 28 11:50:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ken-ichirou MATSUZAWA X-Patchwork-Id: 343364 X-Patchwork-Delegate: regit@netfilter.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id ABA5C140094 for ; Mon, 28 Apr 2014 21:51:02 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752815AbaD1Lu7 (ORCPT ); Mon, 28 Apr 2014 07:50:59 -0400 Received: from mail-pb0-f43.google.com ([209.85.160.43]:38750 "EHLO mail-pb0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbaD1Lu7 (ORCPT ); Mon, 28 Apr 2014 07:50:59 -0400 Received: by mail-pb0-f43.google.com with SMTP id um1so5743748pbc.2 for ; Mon, 28 Apr 2014 04:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=UmFCvYGTbBZA3taPQcDnoS0zH2/TtAZnvm5188tBnoE=; b=b/NAf7k6bCBGK2HPI8Dw7WLSUAXnLIWNJdc7zIgwGRO0bOdrR5nuZ/c5S1tqlKTwRJ elQhJIZUugjln1xryguAqNrh+JbdxhLbxb5TqPfvUSXr7rEiEYCX0AifT+RPvAafoT9L TZl4Jwip2pf/kK1lSFyTxGMxalKOY7jEbvnHDM1sIAUGaIcKvy8GpvFOM/1q0eXPnpoo 65EDdLbxFF+FVw2P7sGrbHWgNLJ6w9kVrQf+c6bojR4PFZlrPbTjRBaEuAsE3Cgshc6P ysse2KDpJB2vFCfInf8ljYyJa0drlCpQRelgJkvOp9u5dksiJydTz5OqKkMaOUS857Ae PCAA== X-Received: by 10.68.164.4 with SMTP id ym4mr25117545pbb.53.1398685858659; Mon, 28 Apr 2014 04:50:58 -0700 (PDT) Received: from gmail.com (softbank220009032006.bbtec.net. [220.9.32.6]) by mx.google.com with ESMTPSA id gg3sm34551109pbc.34.2014.04.28.04.50.56 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 28 Apr 2014 04:50:57 -0700 (PDT) Date: Mon, 28 Apr 2014 20:50:53 +0900 From: Ken-ichirou MATSUZAWA To: The netfilter developer mailinglist Subject: [ulogd PATCH 7/13] ipfix: decide whether prepending template by send times Message-ID: <20140428115053.GH12523@gmail.com> References: <20140308010344.GA4415@gmail.com> <20140428113936.GA12523@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140428113936.GA12523@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org specified in config file and kept it until_template in struct ulogd_ipfix_template Signed-off-by Ken-ichirou MATSUZAWA --- output/ulogd_output_IPFIX.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/output/ulogd_output_IPFIX.c b/output/ulogd_output_IPFIX.c index 8246ed3..4dc4a6c 100644 --- a/output/ulogd_output_IPFIX.c +++ b/output/ulogd_output_IPFIX.c @@ -85,7 +85,7 @@ struct sctp_sndrcvinfo { #define IPFIX_DEFAULT_TCPUDP_PORT 4739 static struct config_keyset ipfix_kset = { - .num_ces = 4, + .num_ces = 5, .ces = { { .key = "host", @@ -110,6 +110,12 @@ static struct config_keyset ipfix_kset = { .options = CONFIG_OPT_NONE, .u.value = 0, }, + { + .key = "send_template_per", + .type = CONFIG_TYPE_INT, + .options = CONFIG_OPT_NONE, + .u.value = 16, + }, }, }; @@ -117,6 +123,7 @@ static struct config_keyset ipfix_kset = { #define port_ce(x) (x->ces[1]) #define proto_ce(x) (x->ces[2]) #define domain_ce(x) (x->ces[3]) +#define template_per_ce(x) (x->ces[4]) struct ipfix_template { struct ipfix_templ_rec_hdr hdr; @@ -129,6 +136,7 @@ struct ulogd_ipfix_template { unsigned int data_length; /* length of the DATA */ void *tmpl_cur; /* cursor into current template position */ struct ipfix_template tmpl; + int until_template; /* decide if it's time to retransmit our template */ }; struct ipfix_instance { @@ -171,6 +179,7 @@ build_template_for_bitmask(struct ulogd_pluginstance *upi, tmpl->tmpl_cur = tmpl->tmpl.buf; tmpl->data_length = 0; + tmpl->until_template = template_per_ce(upi->config_kset).u.value; for (i = 0, j = 0; i < upi->input.num_keys; i++) { struct ulogd_key *key = &upi->input.keys[i]; @@ -368,7 +377,8 @@ static int output_ipfix(struct ulogd_pluginstance *upi) { struct ipfix_instance *ii = (struct ipfix_instance *) &upi->private; struct ulogd_ipfix_template *template; - unsigned int total_size, i; + unsigned int i; + bool need_template = false; /* FIXME: it would be more cache efficient if the IS_VALID * flags would be a separate bitmask outside of the array. @@ -401,16 +411,12 @@ static int output_ipfix(struct ulogd_pluginstance *upi) return ULOGD_IRET_ERR; } llist_add(&template->list, &ii->template_list); + need_template = true; } - total_size = template->data_length; - - /* decide if it's time to retransmit our template and (optionally) - * prepend it into the to-be-sent IPFIX message */ - if (0 /* FIXME */) { - /* add size of template */ - //total_size += (template->tmpl_cur - (void *)&template->tmpl); - total_size += sizeof(template->tmpl); + if (template->until_template-- == 0) { + need_template = true; + template->until_template = template_per_ce(upi->config_kset).u.value; } return ULOGD_IRET_OK;