[RFC,6/7,v2] fwts: Add FWTS_FW_FEATURE_DEVICETREE

This feature indicates the presence of a device-tree.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>

---
 src/lib/include/fwts_firmware.h |    4 +++-
 src/lib/src/fwts_firmware.c     |    1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

On 28/04/14 02:35, Jeremy Kerr wrote:
> This feature indicates the presence of a device-tree.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> 
> ---
>  src/lib/include/fwts_firmware.h |    4 +++-
>  src/lib/src/fwts_firmware.c     |    1 +
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/lib/include/fwts_firmware.h b/src/lib/include/fwts_firmware.h
> index 52d0a85..83a0ba4 100644
> --- a/src/lib/include/fwts_firmware.h
> +++ b/src/lib/include/fwts_firmware.h
> @@ -30,7 +30,9 @@ enum firmware_type {
>  
>  enum firmware_feature {
>  	FWTS_FW_FEATURE_ACPI		= 0x1,
> -	FWTS_FW_FEATURE_ALL		= FWTS_FW_FEATURE_ACPI
> +	FWTS_FW_FEATURE_DEVICETREE	= 0x2,
> +	FWTS_FW_FEATURE_ALL		= FWTS_FW_FEATURE_ACPI |
> +					  FWTS_FW_FEATURE_DEVICETREE
>  };
>  
>  int fwts_firmware_detect(void);
> diff --git a/src/lib/src/fwts_firmware.c b/src/lib/src/fwts_firmware.c
> index 136d617..c67e7b2 100644
> --- a/src/lib/src/fwts_firmware.c
> +++ b/src/lib/src/fwts_firmware.c
> @@ -31,6 +31,7 @@ static struct {
>  	const char name[16];
>  } feature_names[] = {
>  	{ FWTS_FW_FEATURE_ACPI,		"acpi" },
> +	{ FWTS_FW_FEATURE_DEVICETREE,	"devicetree" },
>  };

perhaps "Device Tree", "Device tree", "device tree"? I'm not sure what
the standard name for this is.

>  
>  /*
>

Hi Colin,

>> --- a/src/lib/src/fwts_firmware.c
>> +++ b/src/lib/src/fwts_firmware.c
>> @@ -31,6 +31,7 @@ static struct {
>>  	const char name[16];
>>  } feature_names[] = {
>>  	{ FWTS_FW_FEATURE_ACPI,		"acpi" },
>> +	{ FWTS_FW_FEATURE_DEVICETREE,	"devicetree" },
>>  };
> 
> perhaps "Device Tree", "Device tree", "device tree"? I'm not sure what
> the standard name for this is.

That probably depends on what we want the convention for feature names
within fwts to be; I was going for single-work tokens here.

If we're going for the more human-readable two-word form, I don't think
we'd need to capitalise it, as it's not really a proper noun.

Cheers,


Jeremy