Patchwork [v2,2/2,scsi-post-merge] cxgb3i: support of private MAC address in iSCSI

login
register
mail settings
Submitter Karen Xie
Date Sept. 25, 2009, 10:25 p.m.
Message ID <200909252225.n8PMPaa4031752@localhost.localdomain>
Download mbox | patch
Permalink /patch/34318/
State Deferred
Delegated to: David Miller
Headers show

Comments

Karen Xie - Sept. 25, 2009, 10:25 p.m.
[PATCH v2 2/2 scsi-post-merge] cxgb3i: private MAC address for iSCSI

From: Karen Xie <kxie@chelsio.com>
        
This patch updated the use of private MAC address per port in iscsi.

This patch is generated against scsi-post-merge.
             
Signed-off-by: Karen Xie <kxie@chelsio.com>
--- 
 drivers/scsi/cxgb3i/cxgb3i_offload.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mike Christie - Sept. 26, 2009, 12:36 a.m.
kxie@chelsio.com wrote:
> [PATCH v2 2/2 scsi-post-merge] cxgb3i: private MAC address for iSCSI
> 
> From: Karen Xie <kxie@chelsio.com>
>         
> This patch updated the use of private MAC address per port in iscsi.
> 
> This patch is generated against scsi-post-merge.
>              
> Signed-off-by: Karen Xie <kxie@chelsio.com>
> --- 
>  drivers/scsi/cxgb3i/cxgb3i_offload.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/scsi/cxgb3i/cxgb3i_offload.h b/drivers/scsi/cxgb3i/cxgb3i_offload.h
> index 6a1d86b..f585ece 100644
> --- a/drivers/scsi/cxgb3i/cxgb3i_offload.h
> +++ b/drivers/scsi/cxgb3i/cxgb3i_offload.h
> @@ -234,9 +234,9 @@ struct sge_opaque_hdr {
>   * get and set private ip for iscsi traffic
>   */
>  #define cxgb3i_get_private_ipv4addr(ndev) \
> -	(((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr)
> +	(((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr)
>  #define cxgb3i_set_private_ipv4addr(ndev, addr) \
> -	(((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr) = addr
> +	(((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr) = addr
>  

This looks ok.

Reviewed-by Mike Christie <michaelc@cs.wisc.edu>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/scsi/cxgb3i/cxgb3i_offload.h b/drivers/scsi/cxgb3i/cxgb3i_offload.h
index 6a1d86b..f585ece 100644
--- a/drivers/scsi/cxgb3i/cxgb3i_offload.h
+++ b/drivers/scsi/cxgb3i/cxgb3i_offload.h
@@ -234,9 +234,9 @@  struct sge_opaque_hdr {
  * get and set private ip for iscsi traffic
  */
 #define cxgb3i_get_private_ipv4addr(ndev) \
-	(((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr)
+	(((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr)
 #define cxgb3i_set_private_ipv4addr(ndev, addr) \
-	(((struct port_info *)(netdev_priv(ndev)))->iscsi_ipv4addr) = addr
+	(((struct port_info *)(netdev_priv(ndev)))->iscsic.ipv4_addr) = addr
 
 /* max. connections per adapter */
 #define CXGB3I_MAX_CONN		16384