diff mbox

[jit] Ensure dlerror failures lead to the overall "compilation" failing

Message ID 1398456502-25045-1-git-send-email-dmalcolm@redhat.com
State New
Headers show

Commit Message

David Malcolm April 25, 2014, 8:08 p.m. UTC 
Committed to branch dmalcolm/jit:

gcc/jit/
	* internal-api.c (gcc::jit::playback::context::compile): Put
	any output of dlerror through the add_error method, rather
	than merely printing it to stderr, so that the error is also
	recorded on the context.
---
 gcc/jit/ChangeLog.jit  | 7 +++++++
 gcc/jit/internal-api.c | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/gcc/jit/ChangeLog.jit b/gcc/jit/ChangeLog.jit
index d4ed6cf..ccf8a10 100644
--- a/gcc/jit/ChangeLog.jit
+++ b/gcc/jit/ChangeLog.jit
@@ -1,3 +1,10 @@ 
+2014-04-25  David Malcolm  <dmalcolm@redhat.com>
+
+	* internal-api.c (gcc::jit::playback::context::compile): Put
+	any output of dlerror through the add_error method, rather
+	than merely printing it to stderr, so that the error is also
+	recorded on the context.
+
 2014-03-19  Tom Tromey  <tromey@redhat.com>
 
 	* internal-api.c (compile): Use auto_timevar.
diff --git a/gcc/jit/internal-api.c b/gcc/jit/internal-api.c
index f9f4d8e..f45595e 100644
--- a/gcc/jit/internal-api.c
+++ b/gcc/jit/internal-api.c
@@ -3771,7 +3771,7 @@  compile ()
 
     handle = dlopen (m_path_so_file, RTLD_NOW | RTLD_LOCAL);
     if ((error = dlerror()) != NULL)  {
-      fprintf(stderr, "%s\n", error);
+      add_error (NULL, "%s", error);
     }
     if (handle)
       result_obj = new result (handle);