stdlib/gmp-impl.h: Silence -Wundef warning for USE_STACK_ALLOC
diff mbox

Message ID 1398442297-2854-1-git-send-email-will.newton@linaro.org
State New
Headers show

Commit Message

Will Newton April 25, 2014, 4:11 p.m. UTC
The upstream version of GMP has long removed this conditional
altogether in this commit:

changeset:   5254:88618a4694ac
user:        Kevin Ryde <user42@zip.com.au>
date:        Sun Jun 17 01:37:27 2001 +0200

So just turn the #if into an #ifdef to silence the warning.

ChangeLog:

2014-04-25  Will Newton  <will.newton@linaro.org>

	* stdlib/gmp-impl.h: Test USE_STACK_ALLOC #ifdef
	rather than #if.
---
 stdlib/gmp-impl.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Will Newton May 6, 2014, 9:21 a.m. UTC | #1
On 25 April 2014 17:11, Will Newton <will.newton@linaro.org> wrote:
> The upstream version of GMP has long removed this conditional
> altogether in this commit:
>
> changeset:   5254:88618a4694ac
> user:        Kevin Ryde <user42@zip.com.au>
> date:        Sun Jun 17 01:37:27 2001 +0200
>
> So just turn the #if into an #ifdef to silence the warning.
>
> ChangeLog:
>
> 2014-04-25  Will Newton  <will.newton@linaro.org>
>
>         * stdlib/gmp-impl.h: Test USE_STACK_ALLOC #ifdef
>         rather than #if.
> ---
>  stdlib/gmp-impl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ping?

> diff --git a/stdlib/gmp-impl.h b/stdlib/gmp-impl.h
> index 83865dc..b7da5bd 100644
> --- a/stdlib/gmp-impl.h
> +++ b/stdlib/gmp-impl.h
> @@ -47,7 +47,7 @@ along with the GNU MP Library; see the file COPYING.LIB.  If not, see
>  #endif
>  #endif
>
> -#if ! defined (HAVE_ALLOCA) || USE_STACK_ALLOC
> +#if ! defined (HAVE_ALLOCA) || defined (USE_STACK_ALLOC)
>  #include "stack-alloc.h"
>  #else
>  #define TMP_DECL(m)
> --
> 1.9.0
>
Will Newton May 13, 2014, 9:17 a.m. UTC | #2
On 6 May 2014 10:21, Will Newton <will.newton@linaro.org> wrote:
> On 25 April 2014 17:11, Will Newton <will.newton@linaro.org> wrote:
>> The upstream version of GMP has long removed this conditional
>> altogether in this commit:
>>
>> changeset:   5254:88618a4694ac
>> user:        Kevin Ryde <user42@zip.com.au>
>> date:        Sun Jun 17 01:37:27 2001 +0200
>>
>> So just turn the #if into an #ifdef to silence the warning.
>>
>> ChangeLog:
>>
>> 2014-04-25  Will Newton  <will.newton@linaro.org>
>>
>>         * stdlib/gmp-impl.h: Test USE_STACK_ALLOC #ifdef
>>         rather than #if.
>> ---
>>  stdlib/gmp-impl.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Ping?

Ping?

>> diff --git a/stdlib/gmp-impl.h b/stdlib/gmp-impl.h
>> index 83865dc..b7da5bd 100644
>> --- a/stdlib/gmp-impl.h
>> +++ b/stdlib/gmp-impl.h
>> @@ -47,7 +47,7 @@ along with the GNU MP Library; see the file COPYING.LIB.  If not, see
>>  #endif
>>  #endif
>>
>> -#if ! defined (HAVE_ALLOCA) || USE_STACK_ALLOC
>> +#if ! defined (HAVE_ALLOCA) || defined (USE_STACK_ALLOC)
>>  #include "stack-alloc.h"
>>  #else
>>  #define TMP_DECL(m)
>> --
>> 1.9.0
>>
>
>
>
> --
> Will Newton
> Toolchain Working Group, Linaro
Ondřej Bílka May 13, 2014, 9:54 a.m. UTC | #3
On Tue, May 13, 2014 at 10:17:41AM +0100, Will Newton wrote:
> On 6 May 2014 10:21, Will Newton <will.newton@linaro.org> wrote:
> > On 25 April 2014 17:11, Will Newton <will.newton@linaro.org> wrote:
> >> The upstream version of GMP has long removed this conditional
> >> altogether in this commit:
> >>
> >> changeset:   5254:88618a4694ac
> >> user:        Kevin Ryde <user42@zip.com.au>
> >> date:        Sun Jun 17 01:37:27 2001 +0200
> >>
> >> So just turn the #if into an #ifdef to silence the warning.
> >>
> >> ChangeLog:
> >>
> >> 2014-04-25  Will Newton  <will.newton@linaro.org>
> >>
> >>         * stdlib/gmp-impl.h: Test USE_STACK_ALLOC #ifdef
> >>         rather than #if.
> >> ---
> >>  stdlib/gmp-impl.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Ping?
> 
> Ping?
> 
looks ok.

Patch
diff mbox

diff --git a/stdlib/gmp-impl.h b/stdlib/gmp-impl.h
index 83865dc..b7da5bd 100644
--- a/stdlib/gmp-impl.h
+++ b/stdlib/gmp-impl.h
@@ -47,7 +47,7 @@  along with the GNU MP Library; see the file COPYING.LIB.  If not, see
 #endif
 #endif
 
-#if ! defined (HAVE_ALLOCA) || USE_STACK_ALLOC
+#if ! defined (HAVE_ALLOCA) || defined (USE_STACK_ALLOC)
 #include "stack-alloc.h"
 #else
 #define TMP_DECL(m)